Merged
Conversation
jobselko
approved these changes
Mar 4, 2026
CLAUDE.md
Outdated
| Prefer writing functional tests for new changes/bugfixes and only fallback on unit tests when the change is not easily testable through the API. | ||
|
|
||
| This follows the standard Pulp plugin pattern. The plugin registers itself via the entry point `pulpcore.plugin` → `pulp_python.app.PulpPythonPluginAppConfig`. | ||
| pulp_python functional tests require pulp_python, pulpcore & pulp-file client bindings to be installed. The bindings must be regenerated for any changes to the API spec. |
Contributor
There was a problem hiding this comment.
pulp_file instead of pulp-file
Edit: Actually I am not sure if this matters.
Contributor
Author
There was a problem hiding this comment.
I updated pulp_python to pulp-python. I think this is better since most tools handle this format correctly and convert when needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Checklist
See: Pull Request Walkthrough