Conversation
fixes: pulp#2237 Generated-by: claude-opus-4.6
| return result | ||
|
|
||
|
|
||
| def _extract_inline_sig_data(signature_raw): |
There was a problem hiding this comment.
To be honest I consider this near-unreviewable, I'm not thrilled with the implementation we already have in Pulpcore but I would especially rather not proliferate PGP parsing code out to plugins.
I'd like to investigate whether we can replace both with pysequoia. Sequoia (the base library, at least) is maintained and is "blessed" by RH since new versions of RPM use it. It's guaranteed to support PQC and AFAIK is planned to be the basis for replacing GPG given the ecosystem bifurcation.
There was a problem hiding this comment.
https://github.com/wiktor-k/pysequoia?tab=readme-ov-file#parsing
For the lowest level stuff it may not be possible yet w/ pysequoia but it would not necessarily be that hard to get there, see: wiktor-k/pysequoia#32
The functionality already exists in sequoia, just maybe not exposed. It's also possible that some of that has been added since we last checked.
There was a problem hiding this comment.
I agree about using pysequoia and I even asked claude to use it in my prompt. Then it thought about it for 2 seconds and decided "nah, let me hand write it". 🤡
2 participants
fixes: #2237
Generated-by: claude-opus-4.6
📜 Checklist
See: Pull Request Walkthrough