Merged
Conversation
pedro-psb
force-pushed
the
feat/add-linkchecker-tool2
branch
2 times, most recently
from
f265d19 to
1f79861
Compare
pedro-psb
force-pushed
the
feat/add-linkchecker-tool2
branch
2 times, most recently
from
8a38c1e to
7d7cee4
Compare
pedro-psb
changed the title
pedro-psb
force-pushed
the
feat/add-linkchecker-tool2
branch
4 times, most recently
from
d56e885 to
04bdbc7
Compare
gerrod3
reviewed
Mar 3, 2026
| lint: | ||
| pre-commit run -a | ||
|
|
||
| docs-linkcheck: |
Contributor
There was a problem hiding this comment.
Shouldn't this have a .PHONY?
src/linkchecker/cli.py
Outdated
| return | ||
| print(HEADER_ERROR.format(n=len(link_errors))) | ||
| for error in link_errors: | ||
| # line_str = error.src_line.strip()[:85] + " (...)" |
Contributor
There was a problem hiding this comment.
Is this a leftover comment?
pedro-psb
force-pushed
the
feat/add-linkchecker-tool2
branch
from
04bdbc7 to
46c9d32
Compare
gerrod3
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a link checker cli tool to pulp-docs.
In a first pass, the link checker is designed to only look for internal links that uses
site:PATHsyntax.Probably we want to improve that later.
Closes #34