Fix pulpcore check on test profile task artifact download#1332
Merged
Fix pulpcore check on test profile task artifact download#1332
Conversation
mdellweg
approved these changes
Mar 4, 2026
Backport to 0.38: 💚 backport PR created✅ Backport PR branch: Backported as #1333 🤖 @patchback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix the pulpcore 3.63 and 3.73 CI updates by no longer requiring having to set the TASK_DIAGNOSTICS setting for the cli tests to pass.
Before 3.82 anytime you set TASK_DIAGNOSTICS it would always run the task with the profilers. After 3.82 it will only run the profilers if you specify the header on task creation. The update-ci jobs fail on the domain artifact creation test since the upload task ends up creating an extra profile artifact.