Add test for native to wasm value conversions#525
Open
leonm1 wants to merge 5 commits intoproxy-wasm:mainfrom
Open
Add test for native to wasm value conversions#525leonm1 wants to merge 5 commits intoproxy-wasm:mainfrom
leonm1 wants to merge 5 commits intoproxy-wasm:mainfrom
Conversation
Signed-off-by: Matt Leon <mattleon@google.com>
leonm1
requested review from
PiotrSikora,
martijneken and
mpwarres
as code owners
PiotrSikora
reviewed
Mar 17, 2026
Member
PiotrSikora
left a comment
PiotrSikora
left a comment
There was a problem hiding this comment.
Could you change bigendian to endianness everywhere? We're verifying that values are not incorrectly converted on little-endian systems as well.
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test explicitly tests the bounds of various native and wasm types to ensure passing data across the ABI boundary is not lossy.