Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds a Changeset Enforcement workflow for PRs to detect releasable-code edits and require changesets, and refactors release/publish CI into a reusable workflow used by continuous-release and conditional release preview publishing. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/changeset-enforcement.yml (1)
40-49: Inconsistent pnpm setup approach compared to other workflows.This workflow uses
pnpm/action-setup@v4while the other workflows in this PR usecorepack enable. Both approaches work, but mixing them could lead to version mismatches if the repository'spackageManagerfield inpackage.jsonspecifies a different pnpm version than whatpnpm/action-setupinstalls by default.Consider using the same approach (
corepack enable) for consistency across all workflows, which respects the version pinned inpackage.json.♻️ Suggested change for consistency
- name: Setup pnpm if: steps.scope.outputs.requires_changeset == 'true' - uses: pnpm/action-setup@v4 + run: corepack enable - name: Setup Node.js if: steps.scope.outputs.requires_changeset == 'true'🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/changeset-enforcement.yml around lines 40 - 49, Replace the heterogeneous pnpm setup by removing the pnpm/action-setup@v4 step and using the same "corepack enable" approach as other workflows: update the "Setup pnpm" step (and ensure "Setup Node.js" remains) to run corepack enable so pnpm version respects package.json's packageManager; specifically modify the steps titled "Setup pnpm" and the adjacent "Setup Node.js" in changeset-enforcement.yml to use corepack enable instead of pnpm/action-setup@v4 to keep behavior consistent across workflows.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/changeset-enforcement.yml:
- Around line 40-49: Replace the heterogeneous pnpm setup by removing the
pnpm/action-setup@v4 step and using the same "corepack enable" approach as other
workflows: update the "Setup pnpm" step (and ensure "Setup Node.js" remains) to
run corepack enable so pnpm version respects package.json's packageManager;
specifically modify the steps titled "Setup pnpm" and the adjacent "Setup
Node.js" in changeset-enforcement.yml to use corepack enable instead of
pnpm/action-setup@v4 to keep behavior consistent across workflows.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 8b0774f1-7f07-474d-be6d-8346587ca3c8
📒 Files selected for processing (4)
.github/workflows/changeset-enforcement.yml.github/workflows/continuous-release.yml.github/workflows/publish-any-commit-reusable.yml.github/workflows/release.yml
|
❌ An unexpected error occurred while resolving merge conflicts: Resource not accessible by integration - https://docs.github.com/rest/git/trees#create-a-tree |
Resolves merge conflicts in CI workflows. The skill:check-versions script now exists on main, which was the root cause of the lint CI failure.
@proofkit/better-auth
@proofkit/cli
create-proofkit
@proofkit/fmdapi
@proofkit/fmodata
@proofkit/typegen
@proofkit/webviewer
commit: |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| run: git fetch origin "${{ github.base_ref }}:${{ github.base_ref }}" --depth=1 | ||
|
|
||
| - name: Detect whether this PR touches releasable code | ||
| id: scope | ||
| shell: bash | ||
| run: | | ||
| set -euo pipefail | ||
| CHANGED_FILES=$(git diff --name-only "origin/${{ github.base_ref }}...HEAD") |
There was a problem hiding this comment.
Git reference mismatch will cause incorrect file detection. Line 22 fetches and creates a local branch using origin/${{ github.base_ref }}:${{ github.base_ref }}, but line 29 attempts to diff against origin/${{ github.base_ref }} which expects a remote tracking branch. The colon syntax creates a local branch without updating the remote tracking branch, causing the diff to potentially use stale or missing remote refs.
Fix: Change line 22 to:
run: git fetch origin ${{ github.base_ref }} --depth=1Or change line 29 to use the local branch:
CHANGED_FILES=$(git diff --name-only "${{ github.base_ref }}...HEAD")| run: git fetch origin "${{ github.base_ref }}:${{ github.base_ref }}" --depth=1 | |
| - name: Detect whether this PR touches releasable code | |
| id: scope | |
| shell: bash | |
| run: | | |
| set -euo pipefail | |
| CHANGED_FILES=$(git diff --name-only "origin/${{ github.base_ref }}...HEAD") | |
| run: git fetch origin ${{ github.base_ref }} --depth=1 | |
| - name: Detect whether this PR touches releasable code | |
| id: scope | |
| shell: bash | |
| run: | | |
| set -euo pipefail | |
| CHANGED_FILES=$(git diff --name-only "origin/${{ github.base_ref }}...HEAD") |
Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
1 participant
Summary by CodeRabbit