Skip to content

fix(om2): apply content changes from PR #2851#2919

Merged
dashpole merged 1 commit intomainfrom
krajo/om2-pr2851-content
Mar 25, 2026
Merged

fix(om2): apply content changes from PR #2851#2919
dashpole merged 1 commit intomainfrom
krajo/om2-pr2851-content

Conversation

@krajorama
Copy link
Copy Markdown
Member

Summary

Applies the non-comment content changes from #2851, skipping all //-prefixed TODO/MAYBE/DISCUSSION annotation lines.

  • StateSet: clarify "one Metric with a boolean value per state"; add "for a single Timestamp" to ENUM constraint
  • Info: remove sentence about encoding ENUMs (to be reconsidered separately)
  • Histogram: fix "Histogram Sample" → "Histogram" in Sum definition
  • Histogram/GaugeHistogram: fix typo "the later" → "the latter"
  • Histogram: simplify Start Timestamp sentence (remove "Timestamp value called")
  • Classic Buckets: fix grammar "This allow" → "This allows"; "performance/anti-denial-of-service" → "performance or anti-denial-of-service"; spell out "one second"
  • Native Buckets: "8 bit" → "8-bit"; remove reserved schema value bullet list; use backticks for n, i, i+1; remove "in the following"; fix "an lower" → "a lower"
  • Summary: update description to mention "precomputed quantiles"; reorder SHOULD NOT before backwards compatibility; split Start Timestamp sentence; "relate to" → "be based on"; backtick metric name example
  • Protocol Negotiation: capitalize "Ingestor" mid-sentence
  • ABNF: remove HTML editor note comment

Test plan

  • Verify the changes render correctly in the docs site

Signed-off-by: György Krajcsovits gyorgy.krajcsovits@grafana.com

🤖 Coded with Claude Sonnet 4.6. Generated with Claude Code

Apply non-comment content changes from PR #2851:

- StateSet: clarify "one Metric with a boolean value per state" and
  add "for a single Timestamp" to ENUM constraint
- Info: remove sentence about encoding ENUMs (to be reconsidered)
- Histogram: fix "Histogram Sample" -> "Histogram" in Sum definition
- Histogram/GaugeHistogram: fix "the later" -> "the latter" (typo)
- Histogram: simplify "A Histogram Sample SHOULD have a Start Timestamp"
- Classic Buckets: fix "This allow" -> "This allows" and
  "performance/anti-denial-of-service" -> "performance or anti-denial-of-service"
- Classic Buckets: spell out "one second" instead of "1 second"
- Native Buckets: "8 bit" -> "8-bit"
- Native Buckets: remove reserved schema value details (-9..-5, 9..52, -53)
- Native Buckets: use backticks for n, i, i+1 inline code
- Native Buckets: remove "in the following" from MaxFloat64/MinFloat64 parenthetical
- Native Buckets: fix "an lower" -> "a lower"
- Summary: update description to mention "precomputed quantiles" instead of
  "average event size"
- Summary: move SHOULD NOT sentence before backwards compatibility sentence
- Summary: split Start Timestamp sentence and change "relate to" -> "be based on"
- Summary: add backticks around metric name example
- Protocol Negotiation: capitalize "Ingestor" mid-sentence
- ABNF: remove HTML editor note comment

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Coded with Claude Sonnet 4.6.
@dashpole dashpole merged commit 47324de into main Mar 25, 2026
7 checks passed
@dashpole dashpole deleted the krajo/om2-pr2851-content branch March 25, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants