Fix rendering stall after transition shader on Emscripten / Chrome (v4.1.x)#969
Closed
mbaetgen-wup wants to merge 0 commit intoprojectM-visualizer:v4.1.xfrom
Closed
Conversation
mbaetgen-wup
changed the title
mbaetgen-wup
changed the title
mbaetgen-wup
force-pushed
the
fix/emscripten-transition-bug-4-1-backport
branch
2 times, most recently
from
b38d60d to
b016fa0
Compare
kblaschke
approved these changes
Feb 26, 2026
| // On WebGL2 / Chrome ANGLE, the default framebuffer's draw buffer must | ||
| // be explicitly set to GL_BACK after preset rendering, which may leave | ||
| // per-FBO draw buffer state that leaks into FBO 0 on some drivers. | ||
| GLenum backBuf = GL_BACK; |
Member
There was a problem hiding this comment.
The docs for glDrawBuffers() for OpenGL Core state:
The symbolic constants GL_FRONT, GL_BACK, GL_LEFT, GL_RIGHT, and GL_FRONT_AND_BACK are not allowed in the bufs array since they may refer to multiple buffers.
So this might break rendering on Desktop versions, or at least cause a GL error to be issued.
I'd highly recommend wrapping this in a #ifdef USE_GLES block.
kblaschke
requested changes
Feb 26, 2026
Member
kblaschke
left a comment
kblaschke
left a comment
There was a problem hiding this comment.
Somehow the wrong option was selected, I wanted to request changes. See above.
mbaetgen-wup
force-pushed
the
fix/emscripten-transition-bug-4-1-backport
branch
from
b016fa0 to
efeb3ba
Compare
kblaschke
force-pushed
the
fix/emscripten-transition-bug-4-1-backport
branch
from
efeb3ba to
23cb45b
Compare
github-project-automation
bot
moved this from In Review
to Done
in libprojectM Release 4.1
Member
|
Somehow GH closed the PR despite being merged. Ignore the status, the commit was indeed merged to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.