Skip to content

Add tests for mode +l#333

Merged
progval merged 14 commits intomasterfrom
limit
Mar 8, 2026
Merged

Add tests for mode +l#333
progval merged 14 commits intomasterfrom
limit

Conversation

@progval
Copy link
Copy Markdown
Owner

@progval progval commented Jan 10, 2026

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 10, 2026

Test results

@progval
Copy link
Copy Markdown
Owner Author

progval commented Jan 10, 2026 •
edited
Loading

Reported to Unreal at https://bugs.unrealircd.org/view.php?id=6602

and to Ergo at ergochat/ergo#2324

@progval progval mentioned this pull request Jan 10, 2026
Closed
@progval
Copy link
Copy Markdown
Owner Author

progval commented Jan 10, 2026

Spec PR to formalize testLimitWithInvite: ircdocs/modern-irc#269

but not all IRCds support it so I'm not sure what do to with testLimitWithInvite.

@slingamn
Copy link
Copy Markdown
Collaborator

slingamn commented Jan 10, 2026

The ergo issue here should be fixed in irctest_stable now.

@slingamn
Copy link
Copy Markdown
Collaborator

slingamn commented Jan 20, 2026

re. testLimitWithInvite can we just mark all the ircds that don't support it as expected-fail? That seems OK for a MAY in the Modern spec, if it's a widely implemented and useful feature.

@progval
Copy link
Copy Markdown
Owner Author

progval commented Jan 20, 2026

no, expected-fail is SHOULD/MUST. For MAY it's raise runner.ImplementationChoice("...")

@slingamn
Copy link
Copy Markdown
Collaborator

slingamn commented Jan 21, 2026

But at a pragmatic level, that allows implementations that support the feature to silently regress, right?

@progval
Copy link
Copy Markdown
Owner Author

progval commented Jan 21, 2026

yes

@slingamn slingamn mentioned this pull request Jan 25, 2026
Merged
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 1, 2026

Test results

@slingamn
Copy link
Copy Markdown
Collaborator

slingamn commented Feb 8, 2026

@progval irc2 is unmaintained so we should just x-fail it here, right?

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 8, 2026

Test results

@progval
Copy link
Copy Markdown
Owner Author

progval commented Feb 8, 2026

yes

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 8, 2026

Test results

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 1, 2026

Test results

@slingamn
Copy link
Copy Markdown
Collaborator

slingamn commented Mar 1, 2026

Hmm, SecretChannelTestCase.testSecretChannelListCommand used to be deselected for Sable, but now it's selected and failing.

progval
progval commented Mar 1, 2026
View reviewed changes
Comment thread Makefile Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 1, 2026

Test results

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 7, 2026

Test results

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 7, 2026

Test results

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 8, 2026

Test results

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 8, 2026

Test results

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 8, 2026

Test results

@progval progval merged commit 0d10caf into master Mar 8, 2026
82 checks passed
@progval progval deleted the limit branch March 8, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@progval @slingamn