Develop codemirror v6#4067
Open
mmendieta2 wants to merge 7 commits intoprocessing:develop-codemirror-v6from
Open
Develop codemirror v6#4067mmendieta2 wants to merge 7 commits intoprocessing:develop-codemirror-v6from
mmendieta2 wants to merge 7 commits intoprocessing:develop-codemirror-v6from
Conversation
Co-authored-by: Diego Salvaleon <dsalvaleon1@toromail.csudh.edu>
Release EnvironmentsThis Environment is provided by Release, learn more! 🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-3af4535a2a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #3869
Fixes #
Added tests for stateUtils.js. Testing for file types were added, with no issues. Testing for user prefences were added, although the "autocomplete" div does not get the property "aria-autocomplete" upon creation of the fileState. Testing for tidy code was added, but the keymap itself does not trigger.
Changes:
A new file named stateUtils.test.js was created for testing.
I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123