Skip to content

Rack 2 and Rack 3 compatibility #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clucas wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Rack 2 and Rack 3 compatibility #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
76935ed
Rack 2 and Rack 3 support
clucas Mar 2, 2026
a6f52fe
update gemspec
clucas Mar 2, 2026
f256fcd
bundler config
clucas Mar 2, 2026
ea02b9a
restrict to Rack 3
clucas Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/prerender_rails.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,10 @@ def get_prerender_service_url


def build_rack_response_from_prerender(prerendered_response)
response = Rack::Response.new(prerendered_response.body, prerendered_response.code, prerendered_response)
headers = {}
prerendered_response.each_header { |key, value| headers[key] = value }

response = Rack::Response.new(prerendered_response.body, prerendered_response.code, headers)

@options[:build_rack_response_from_prerender].call(response, prerendered_response) if @options[:build_rack_response_from_prerender]

Expand Down
4 changes: 2 additions & 2 deletions prerender_rails.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ Gem::Specification.new do |spec|
spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
spec.require_paths = ["lib"]

spec.add_dependency 'rack', '~> 2.2.2'
spec.add_dependency 'rack', '>= 2.2', '< 4'
spec.add_dependency 'activesupport', '>= 0'

spec.add_development_dependency "bundler", "~> 2.1.2"
spec.add_development_dependency "bundler", ">= 2.1"
spec.add_development_dependency "rake"
spec.add_development_dependency "webmock"
end
13 changes: 9 additions & 4 deletions test/lib/prerender_rails.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

assert_equal response[2], ["<html></html>"]
assert_equal response[0], 301
assert_equal( { 'location' => 'http://google.com'}, response[1] )
assert_equal 'http://google.com', response[1]['location']
end


Expand Down Expand Up @@ -156,7 +156,7 @@

assert_equal ["<html>cached2</html>"], response[2]
assert_equal response[0], 200
assert_equal( { 'test' => 'test2Header'}, response[1] )
assert_equal 'test2Header', response[1]['test']
end

it "should return a prerendered response stripped of hop-by-hop headers" do
Expand All @@ -177,7 +177,10 @@

assert_equal response[2], ["<html></html>"]
assert_equal response[0], 401
assert_equal( { 'content-type' => 'text/html', 'x-drop-test' => 'ShouldAlwaysHappen'}, response[1] )
assert_equal 'text/html', response[1]['content-type']
assert_equal 'ShouldAlwaysHappen', response[1]['x-drop-test']
assert_nil response[1]['transfer-encoding']
assert_nil response[1]['connection']
end

it "should return a prerendered response stripped of custom-defined hop-by-hop headers" do
Expand All @@ -193,7 +196,9 @@

assert_equal response[2], ["<html></html>"]
assert_equal response[0], 200
assert_equal( { 'content-type' => 'text/html' }, response[1] )
assert_equal 'text/html', response[1]['content-type']
assert_nil response[1]['x-drop-test']
assert_nil response[1]['connection']
end

describe '#buildApiUrl' do
Expand Down