Fix: reset rows count before executing new queries on a connection #1120
Open
ilanfrai wants to merge 2 commits intoporsager:masterfrom
Open
Fix: reset rows count before executing new queries on a connection #1120ilanfrai wants to merge 2 commits intoporsager:masterfrom
ilanfrai wants to merge 2 commits intoporsager:masterfrom
Conversation
ilanfrai
changed the title
porsager
force-pushed
the
master
branch
2 times, most recently
from
4a0fe34 to
3a43815
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR attempts to fix issue #1119
Currently the rows count is only set to 0 in the
CommandCompletehandler, but in case of an error this handler isn't called.I changed the rows reset to be also on the query prepare handler which is called any time a query starts execution. This is in the same place where other variables are cleared (e.g. the result).
I also added a new test that checks this scenario (fails before the fix and passes once fix is applied)