Use munge_search_term from plone.base, fix multi-word wildcard#183
Merged
Use munge_search_term from plone.base, fix multi-word wildcard#183
Conversation
4 tasks
|
@jensens thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
jensens
force-pushed
the
fix/4205-munge-search-term
branch
from
69d56f8 to
0fc475d
Compare
Member
Author
|
we are red here until plone/plone.base#117 is merged |
Replace local munge_search_term and helpers with import from plone.base.utils. Add zope.deferredimport deprecation shim for the old import path (will be removed in Plone 7). Update test expectations for the fixed wildcard behavior. Refs plone/Products.CMFPlone#4205
jensens
force-pushed
the
fix/4205-munge-search-term
branch
from
0fc475d to
690693c
Compare
Member
Author
|
Merge order is: plone.base first, then the other two PRs will pass GHA automatically. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
munge_search_termand helpers with import fromplone.base.utilszope.deferredimportdeprecation shim for old import path (will be removed in Plone 7)*suffixRefs plone/Products.CMFPlone#4205
Depends on: plone/plone.base#117
Companion PR: plone/Products.CMFPlone#4305
Details
The
munge_search_termfunction was a copy from Products.CMFPlone (introduced in 2.0.2 to break a circular dependency). Now thatplone.baseis the canonical location, this package imports from there. TheQueryBuilder.munge_search_term(self, q)instance method wrapper is kept as a subclass hook.The old import path
plone.app.querystring.querybuilder.munge_search_termstill works but emits a deprecation warning.Test plan
test_munge_search_termexpectations for new wildcard behaviorplone.base.utils(canonical location)🤖 Generated with Claude Code