Skip to content

Add new session variable "tidb_opt_partial_ordered_index_for_topn"#22495

Merged
ti-chi-bot[bot] merged 6 commits intopingcap:masterfrom
qiancai:partial_order_by-21318
Apr 13, 2026
Merged

Add new session variable "tidb_opt_partial_ordered_index_for_topn"#22495
ti-chi-bot[bot] merged 6 commits intopingcap:masterfrom
qiancai:partial_order_by-21318

Conversation

@qiancai
Copy link
Copy Markdown
Collaborator

@qiancai qiancai commented Feb 26, 2026

First-time contributors' checklist

What is changed, added or deleted? (Required)

Explain the new session variable "tidb_opt_partial_ordered_index_for_topn" in sys-var doc

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Related issue: pingcap/tidb#65813

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qiancai qiancai added needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Feb 26, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @qiancai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to document the new "tidb_opt_partial_ordered_index_for_topn" session variable within the TiDB system variable documentation. While the current patch includes a temporary file, the primary goal is to provide clear information for this new configuration option, ensuring users understand its purpose and usage.

Highlights

  • Documentation Update: Prepared documentation for the new session variable "tidb_opt_partial_ordered_index_for_topn", which will be added to the system variable documentation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • temp.md
    • Added a new temporary file.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ti-chi-bot ti-chi-bot Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 26, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is intended to add documentation for the tidb_opt_partial_ordered_index_for_topn session variable. However, the current changes only add a file named temp.md with placeholder content. The actual documentation changes appear to be missing. Please update the pull request to include the correct files.

I am having trouble creating individual review comments. Click here to see my feedback.

temp.md (1)

low

It is a common convention for text files to end with a newline character. This prevents potential issues with some command-line tools and version control systems.

This is a test file.

Synced from: pingcap/docs-cn#21318
Target PR: pingcap#22495
AI Provider: gemini

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@ti-chi-bot ti-chi-bot Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 26, 2026
@qiancai qiancai self-assigned this Mar 26, 2026
@qiancai
Copy link
Copy Markdown
Collaborator Author

qiancai commented Mar 30, 2026

/cc @qw4990

@ti-chi-bot ti-chi-bot Bot requested a review from qw4990 March 30, 2026 08:19
Comment thread system-variables.md
Comment thread system-variables.md Outdated
Comment thread system-variables.md Outdated
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 3, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 3, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-04-03 04:04:42.481986075 +0000 UTC m=+497087.687346122: ☑️ agreed by Oreoxmt.

Co-authored-by: Aolin <aolinz@outlook.com>
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 3, 2026

@qw4990: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@qiancai qiancai added the lgtm label Apr 13, 2026
@qiancai
Copy link
Copy Markdown
Collaborator Author

qiancai commented Apr 13, 2026

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Apr 13, 2026
@ti-chi-bot ti-chi-bot Bot merged commit 7535010 into pingcap:master Apr 13, 2026
12 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Apr 13, 2026
Synced from: pingcap/docs-cn#21318
Target PR: pingcap#22495
AI Provider: gemini

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #22737.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants