Fix counting sscanf/fscanf format string placeholders#5594
Open
hakre wants to merge 2 commits intophpstan:2.1.xfrom
Open
Fix counting sscanf/fscanf format string placeholders#5594hakre wants to merge 2 commits intophpstan:2.1.xfrom
sscanf/fscanf format string placeholders#5594hakre wants to merge 2 commits intophpstan:2.1.xfrom
Conversation
hakre
force-pushed
the
patch-1
branch
4 times, most recently
from
57da830 to
5742f2b
Compare
hakre
changed the title
sscanf/fscanf format string placeholderssscanf/fscanf format string placeholders
Make `public function getScanfPlaceholdersCount(string $format): ?int` returning the sscanf() vetted number of placeholders that give/return/assign conversions. refs: - phpstan#5591 - phpstan/phpstan#14567
Collaborator
|
This pull request has been marked as ready for review. |
staabm
reviewed
May 6, 2026
| $throws = $this->phpVersion->throwsValueErrorForInternalFunctions(); | ||
| try { | ||
| if ($throws === false) { | ||
| set_error_handler( |
Contributor
There was a problem hiding this comment.
why do we need this error-handler/try-catch construction?
we don't need it in other rules/rule-helpers?
Contributor
There was a problem hiding this comment.
could we use @sscanf() instead and check the return type?
staabm
reviewed
May 6, 2026
Comment on lines
+38
to
+39
| sscanf($str, '%.E', $number); // bad scan conversion character '.' | ||
| fscanf($str, '%.E', $number); // bad scan conversion character '.' |
Contributor
There was a problem hiding this comment.
Suggested change
| sscanf($str, '%.E', $number); // bad scan conversion character '.' | |
| fscanf($str, '%.E', $number); // bad scan conversion character '.' | |
| sscanf($str, '%.E', $number); // bad scan conversion character '.' | |
| fscanf($resource, '%.E', $number); // bad scan conversion character '.' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update PrintfHelper.php:
Make
public function getScanfPlaceholdersCount(string $format): ?intreturning the sscanf() vetted number of placeholders that give/return/assign conversions.refs:
sscanf/fscanfformat string at NUL byte before counting placeholders #5591