Zend: Fix leaks when destructors throw during shutdown#22020
Closed
LamentXU123 wants to merge 1 commit into
Closed
Zend: Fix leaks when destructors throw during shutdown#22020LamentXU123 wants to merge 1 commit into
LamentXU123 wants to merge 1 commit into
Conversation
Member
|
Thank you @LamentXU123. Thinking more about it, I'm not sure we should fix this. It's probably better to avoid executing too much code after a bailout. This happens during shutdown, so the leak is going to resolve itself when the heap is reset. |
Member
|
Yes, we don't care about leaks in the bailout ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as per #22010, this is *probably* because if shutdown aborts, while unwinding from the thrown exception, the matching
GC_DELREF()/OBJ_RELEASE()calls may be skipped. That means, we need to add a catch logic to make sure that the object is released.cc @arnaud-lb. See if this works :)