Add support for generating the namespace for the manual#21313
Add support for generating the namespace for the manual#21313kocsismate wants to merge 1 commit intophp:PHP-8.5from
Conversation
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
Reviewing gen_stub code is always difficult due to the lack of tests :/
| $package->setAttribute("modifier", "namespace"); | ||
| $package->setAttribute("class", $namespace); |
There was a problem hiding this comment.
You don't need this, the renderer takes care of adding the namespace.
DanielEScherzer
left a comment
DanielEScherzer
left a comment
There was a problem hiding this comment.
agree that reviewing is hard, especially for patches that change the documentation generation rather than stubs - noticed one thing that might make it easier to review, but I don't think I'm qualified to actually approve this
|
|
||
| /** @param array<string, ConstInfo> $allConstInfos */ | ||
| public function getFieldSynopsisElement(DOMDocument $doc, array $allConstInfos): DOMElement | ||
| public function getFieldSynopsisElement(DOMDocument $doc, array $allConstInfos, int $indentationLevel): DOMElement |
There was a problem hiding this comment.
can we do the indentation changes on a separate commit, even if it is in the same PR? I assume that the initial indentation changes were meant to be no-ops, and just make things useful for indenting in a namespace later, but I can't really tell
3 participants
Based on php/phd#194