Add stream socket so_linger context option#20808
Open
bukka wants to merge 3 commits intophp:masterfrom
Open
Conversation
devnexen
reviewed
Dec 30, 2025
This adds so_linger stream socket context options that is used to set the lingering time in seconds. If the value is lower or equal to 0, then the lingering is disabled.
Member
Author
Member
I just double checked, but FreeBSD set l_onoff field by masking with SO_LINGER (which is 0x0080) l.l_onoff = so->so_options & SO_LINGER; |
devnexen
reviewed
Mar 7, 2026
| if (sockvals->mask & PHP_SOCKVAL_SO_LINGER) { | ||
| struct linger linger_val = { | ||
| .l_onoff = (sockvals->linger > 0), | ||
| .l_linger = (unsigned short)sockvals->linger |
Member
There was a problem hiding this comment.
the only subtlety is setting l_onoff with 1 but with l_linger with 0 is a valid use case (closing connection w/o handshake aka RST on close) but you can only carry one value per socket option right ?
Member
There was a problem hiding this comment.
saying that, even rust expresses this in a similar way I just recalled having pushing a PR in there :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds so_linger stream socket context options that is used to set the lingering time in seconds. If the value is lower or equal to 0, then the lingering is disabled.