Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enforces JSON-compatible step outputs at
.step()construction time by adding TypeScript constraints to the step handler functions.The changes introduce a
Jsontype constraint on step handler return values, preventing non-serializable types likeundefined,Symbol, or functions from being returned. A newWidenJson<T>utility type is added to properly widen literal types (e.g.,123becomesnumber) while maintaining JSON compatibility.All six
.step()method overloads are updated to use a constrainedTHandlertype parameter instead of a genericTOutput, ensuring type safety at compile time. Comprehensive type tests verify that valid JSON types are accepted while invalid types likeundefinedand functions are properly rejected with TypeScript errors.