feat: implement issue #323 — Compliance: non-stub-dev-lead.yml#337
feat: implement issue #323 — Compliance: non-stub-dev-lead.yml#337don-petry wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
| # compliance-ci-trigger | ||
| # ci-trigger-298 | ||
| .dev-lead/ | ||
| .dev-lead/ |
There was a problem hiding this comment.
The entry .dev-lead/ is already present in this file on line 12 (and lines 8-9). This duplicate entry is redundant and can be removed.
📝 WalkthroughWalkthroughThis PR updates GitHub Actions workflow configuration and repository gitignore. The ci-failure-analyst workflow is reformatted with single-quoted YAML strings. The dev-lead workflow adds concurrency controls to prevent simultaneous runs per repository, using commit-specific groups for check-run triggers. The gitignore is updated to exclude local dev-lead artifacts. ChangesWorkflow and Configuration Updates
Estimated Code Review Effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly Related Issues
Suggested Reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 46b6806026
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| github.event_name == 'check_run' && format('dev-lead-ci-relay-{0}', github.event.check_run.head_sha) || | ||
| 'dev-lead' | ||
| }} | ||
| cancel-in-progress: false |
There was a problem hiding this comment.
With cancel-in-progress: false and no queue setting, GitHub Actions keeps only one pending run per concurrency group by default and cancels older pending runs when new events arrive. Because this workflow is triggered by high-frequency events (issue_comment, review comments, PR sync, etc.), overlapping activity while one run is in progress will silently drop intermediate dev-lead invocations, so some user/CI signals may never be processed. Add queue: max (or split groups) if you need all queued events to run.
Useful? React with 👍 / 👎.
|
There was a problem hiding this comment.
Pull request overview
This PR aims to resolve compliance issue #323 by bringing the repository’s dev-lead.yml workflow in line with the organization’s “thin caller stub” standard.
Changes:
- Added a
concurrencyconfiguration to the Dev-Lead workflow. - Added an additional
.dev-lead/ignore entry to.gitignore.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.gitignore |
Adds another .dev-lead/ entry (currently creating additional duplication). |
.github/workflows/dev-lead.yml |
Introduces a concurrency group intended to control parallel Dev-Lead runs. |
| cancel-in-progress: false | ||
|
|
||
| jobs: | ||
| dev-lead: | ||
| uses: petry-projects/.github-private/.github/workflows/dev-lead-reusable.yml@main |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.gitignore (1)
8-13:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winConsolidate duplicate
.dev-lead/entries.The pattern
.dev-lead/appears four times (lines 8, 9, 12, and 13). Please consolidate these into a single entry.🧹 Proposed fix to remove duplicates
.env *.pem *.key .dev-lead/ -.dev-lead/ -# compliance-ci-trigger -# ci-trigger-298 -.dev-lead/ -.dev-lead/ +# compliance-ci-trigger +# ci-trigger-298🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.gitignore around lines 8 - 13, Consolidate duplicate ignore entries by replacing the four repeated ".dev-lead/" lines in .gitignore with a single ".dev-lead/" entry; remove the extra duplicate lines and scan the file for any other repeated patterns (e.g., other identical directory patterns like "ci-trigger-298" or "compliance-ci-trigger") to ensure each ignore pattern is listed only once.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In @.gitignore:
- Around line 8-13: Consolidate duplicate ignore entries by replacing the four
repeated ".dev-lead/" lines in .gitignore with a single ".dev-lead/" entry;
remove the extra duplicate lines and scan the file for any other repeated
patterns (e.g., other identical directory patterns like "ci-trigger-298" or
"compliance-ci-trigger") to ensure each ignore pattern is listed only once.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 99f34d49-4bf7-498a-92d6-84965020bd3c
📒 Files selected for processing (3)
.github/workflows/ci-failure-analyst.yml.github/workflows/dev-lead.yml.gitignore
Closes #323
Implemented by dev-lead agent. Please review.
Summary by CodeRabbit