Skip to content

feat: implement issue #375 — Compliance audit — 2026-05-29#376

Open
don-petry wants to merge 4 commits into
mainfrom
dev-lead/issue-375-20260529-1558
Open

feat: implement issue #375 — Compliance audit — 2026-05-29#376
don-petry wants to merge 4 commits into
mainfrom
dev-lead/issue-375-20260529-1558

Conversation

@don-petry
Copy link
Copy Markdown
Contributor

@don-petry don-petry commented May 29, 2026

Closes #375

Implemented by dev-lead agent. Please review.

Summary by CodeRabbit

  • Chores
    • Added GitHub Actions workflow to automate environment setup and verification steps for Copilot cloud agent integration
    • Updated configuration to exclude development directories from version control

Review Change Stack

@don-petry don-petry requested a review from a team as a code owner May 29, 2026 16:05
Copilot AI review requested due to automatic review settings May 29, 2026 16:05
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

Warning

Review limit reached

@don-petry, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 50 minutes and 7 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: f1f8ccb5-54ed-4341-a3ac-57ca29fc879b

📥 Commits

Reviewing files that changed from the base of the PR and between b0a4c1c and f9d2025.

📒 Files selected for processing (3)
  • .github/workflows/copilot-setup-steps.yml
  • .gitignore
  • standards/workflows/copilot-setup-steps.yml
📝 Walkthrough

Walkthrough

This PR introduces a Copilot cloud agent setup workflow template at .github/workflows/copilot-setup-steps.yml with documentation, conditional triggers, a fork-origin guard, stack-specific setup stubs, and environment verification validation. It also adds .dev-lead/ to .gitignore.

Changes

Copilot Cloud Agent Setup

Layer / File(s) Summary
Workflow template documentation and triggers
\.github/workflows/copilot-setup-steps.yml``
Defines the required workflow job name, template header documentation, metadata (name and description), trigger conditions (manual, path-scoped push, path-scoped pull request), and workflow-level permission reset for defense-in-depth.
Job setup with stack-specific configuration
\.github/workflows/copilot-setup-steps.yml``
Implements the copilot-setup-steps job with fork-origin PR guard that skips external forks, per-job minimal contents read permission, and commented configuration stubs for installing dependencies across Node/npm, Node/pnpm, Go, and Python stacks, plus optional gh-aw MCP extension installation.
Environment verification and repository configuration
\.github/workflows/copilot-setup-steps.yml`, `.gitignore``
Adds the required Verify environment step that prints repository, ref, and runner details; reports installed tool versions (git, gh, node, npm, go, python); validates AGENTS.md presence as a hard failure; optionally checks .github/copilot-instructions.md; and counts .github/instructions/*.instructions.md files. Updates .gitignore to exclude .dev-lead/ directory.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related issues

  • #375 (Compliance audit — 2026-05-29): This PR directly addresses the Agent Standards workflow findings (copilot-setup-steps-invalid-job-name errors) identified in the compliance audit by providing a valid workflow template with the required copilot-setup-steps job name and environment verification.

Suggested labels

needs-human-review

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR only addresses Agent Standards findings (copilot-setup-steps.yml) from issue #375 but completely omits the other five remediation categories (Repository Settings, Push Protection & Secret Scanning, Workflows, Action SHA Pinning, Dependabot Configuration) affecting the .github repository. Include comprehensive changes addressing all applicable remediation categories from issue #375 for the .github repository, or split into separate focused PRs per category to match the audit findings scope.
Title check ❓ Inconclusive The title 'feat: implement issue #375 — Compliance audit — 2026-05-29' is vague and generic, using non-descriptive terms that don't convey the specific technical changes in the changeset (copilot-setup-steps.yml workflow and .gitignore update). Clarify the title to specifically mention the primary technical changes, e.g., 'feat: add copilot-setup-steps workflow and update .gitignore for .dev-lead directory'
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Out of Scope Changes check ✅ Passed Both changes (copilot-setup-steps.yml and .gitignore .dev-lead entry) directly relate to issue #375's Agent Standards and compliance audit findings; however, the .dev-lead directory exclusion appears to be a complementary fix rather than an explicitly listed finding.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev-lead/issue-375-20260529-1558

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a duplicate ".dev-lead/" entry to the .gitignore file. The review feedback correctly identifies this redundancy and suggests removing the duplicate line.

Comment thread .gitignore Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the org-standard copilot-setup-steps.yml workflow template to the .github repo to bootstrap Copilot cloud agent environments, and updates .gitignore for the .dev-lead/ agent working directory. Part of the 2026-05-29 compliance audit remediation.

Changes:

  • Adds new .github/workflows/copilot-setup-steps.yml template with optional Node/Go/Python stack blocks, fork-PR guard, and environment verification step.
  • Adds a .dev-lead/ entry to .gitignore (duplicates an existing entry).

Reviewed changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.

File Description
.github/workflows/copilot-setup-steps.yml New Tier-2 template workflow for Copilot cloud agent setup with required checkout + verify steps and commented-out stack blocks.
.gitignore Adds .dev-lead/ ignore entry (already present on the line above).

@don-petry
Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@don-petry
Copy link
Copy Markdown
Contributor Author

Dev-Lead — fix-bot-comment (applied)

Changes committed and pushed.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

https://github.com/petry-projects/.github/blob/b0a4c1c1d98a9561ddedd21c11b9bc8631d55d6f/actionlint#L1
P2 Badge Remove the committed actionlint executable

This adds a 5.1 MB Linux executable to the repository root even though the CI workflow already downloads and checksum-verifies actionlint before invoking ./actionlint in .github/workflows/ci.yml. Keeping this unreviewable binary in source control bloats every checkout and can mislead local or future automation into running the committed artifact instead of the verified download; remove it and rely on the existing installer step.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/copilot-setup-steps.yml:
- Around line 91-92: Update the upstream workflow template so the "Checkout
code" step that uses actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
includes persist-credentials: false; modify the upstream
standards/workflows/copilot-setup-steps.yml (not the per-repo copy) to add
persist-credentials: false to the actions/checkout step, then re-sync the
template to propagate the change to this repo.

In @.gitignore:
- Around line 392-393: Remove the duplicate `.dev-lead/` entry (the repeated
line shown) and move a single `.dev-lead/` line out of below the "End of
petry-projects secrets baseline" footer into the main body (place it in the
agent/worktrees section, e.g., section 13), ensuring the footer remains the
final block; delete the extra occurrence so only one `.dev-lead/` entry exists
in the designated section.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: ded7b92c-914a-419d-b2bd-fbe37a28fa0f

📥 Commits

Reviewing files that changed from the base of the PR and between 3f861e1 and b0a4c1c.

📒 Files selected for processing (3)
  • .github/workflows/copilot-setup-steps.yml
  • .gitignore
  • actionlint

Comment thread .github/workflows/copilot-setup-steps.yml
Comment thread .gitignore Outdated
coderabbitai[bot]
coderabbitai Bot previously approved these changes May 29, 2026
@don-petry
Copy link
Copy Markdown
Contributor Author

Dev-Lead — fix-reviews (applied)

Changes committed and pushed.

@sonarqubecloud
Copy link
Copy Markdown

@don-petry
Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compliance audit — 2026-05-29

3 participants