Skip to content

Simple approach to handling the extra instance attrs #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nsheff wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Simple approach to handling the extra instance attrs #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion attmap/attmap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,18 @@ def _metamorph_maplike(self, m: Mapping) -> "AttMap":
raise TypeError(
"Cannot integrate a non-Mapping: {}\nType: {}".format(m, type(m))
)
return self._lower_type_bound(m.items())
# Merge any extra instance attributes from non-builtin Mappings
# so they aren't lost during type conversion.
extra = []
try:
extra = [
(k, v)
for k, v in vars(m).items()
if not k.startswith("_") and k not in m
]
except TypeError:
pass
return self._lower_type_bound(list(m.items()) + extra)

def _new_empty_basic_map(self) -> dict:
"""Return the empty collection builder for Mapping type simplification."""
Expand Down