refactor(cli): hoist fs and path requires to top of bin/confluence.js#179
Merged
Conversation
The fs and path modules were being re-required inline inside 13 command action handlers, adding noise to each handler body. Hoist a single require for each module to the top of the file alongside the other top-level imports. No behavior change — Node caches require results, so the inline declarations were already no-ops on subsequent calls.
|
🎉 This PR is included in version 2.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
const fs = require('fs');andconst path = require('path');to the top ofbin/confluence.jsalongside the other module imports.requireresults, so the inline declarations were redundant — this is purely a readability/maintainability cleanup.Test plan
npm run lint— passesnpm test— 669 tests across 15 suites passconst fs|path = require(...)matches inbin/confluence.js