chore(lint): remove legacy .eslintrc.js superseded by flat config#178
Merged
Conversation
ESLint 9 only loads eslint.config.js and ignores .eslintrc.js, so the legacy file was dead config that misrepresented the active rules. The flat config in eslint.config.js already covers all rules from the legacy file (with an additional caughtErrors: 'none' for unused-vars).
|
🎉 This PR is included in version 2.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.eslintrc.js. ESLint 9 only loadseslint.config.js(flat config) and silently ignores legacy.eslintrc.*files, so the file was dead config that misrepresented the rules actually applied duringnpm run lint.eslint.config.jsalready mirrors every rule from the legacy file (indent,linebreak-style,quotes,semi,no-unused-vars,no-console,no-process-exit) and addscaughtErrors: 'none'. No behavior change.Test plan
npm run lint— passes with no errorsnpm test— 669 tests across 15 suites pass.eslintrcin.github/,package.jsonscripts, or any source file