fix(ui): strip customComponents from rows in reduceToSerializableFields#16787
Open
codeplott wants to merge 1 commit into
Open
fix(ui): strip customComponents from rows in reduceToSerializableFields#16787codeplott wants to merge 1 commit into
codeplott wants to merge 1 commit into
Conversation
The reducer only stripped customComponents from top-level field entries. Each Row carries its own customComponents (RowLabel) that can hold non-serializable refs. Under the Mongo adapter the rendered tree closes back to BasePayload via db.payload, so JSON.stringify on form state throws. This breaks PreviewField and the Auto-generate buttons in plugin-seo. Fixes payloadcms#16786
codeplott
requested review from
AlessioGr,
JarrodMFlesch and
jacobsfletch
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Make
reduceToSerializableFieldsalso stripcustomComponentsfrom each entry inrows[].Why?
The reducer only stripped customComponents from top-level field entries. Each Row carries its own customComponents (RowLabel) that can hold non-serializable refs. Under the Mongo adapter the rendered tree closes back to BasePayload via db.payload, so JSON.stringify on form state throws. This breaks PreviewField and the Auto-generate buttons in plugin-seo.
Fixes #
#16786