Draft
Conversation
Collaborator
Coverage Report for CI Build 24466348066Coverage increased (+0.1%) to 84.488%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
chavic
force-pushed
the
chavic/retry-expiration-metadata-1272
branch
from
23af96e to
0b9fa5f
Compare
Add retryability and expiration accessors to the core v2 session, transport, replay, and response errors, then export the same metadata through the existing UniFFI object wrappers. This lets bindings distinguish expired sessions from transient directory failures without parsing display strings or collapsing everything into opaque transport errors.
chavic
force-pushed
the
chavic/retry-expiration-metadata-1272
branch
from
0b9fa5f to
8e36a85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1272.
This PR surfaces retryability and expiration metadata through the existing sender, receiver, transport, and replay error wrappers. Core already knew when a session had expired and when certain transport failures were retryable, but that information was not being exported over FFI, so bindings had to treat many failures as opaque.
The change adds retryability helpers and expiration timestamp accessors where that information already existed in core, then exports those through the current UniFFI object wrappers rather than introducing a new exception hierarchy. That keeps the branch focused on metadata instead of replaying the broader structural refactors from adjacent issues.
The result is that bindings can now distinguish expired sessions from retryable directory failures and make sane retry or abandon decisions without parsing human-readable messages. This gives cross-language clients the lifecycle metadata they need while staying additive and low-risk.