Column order issue on select statement - task - https://app.clickup.c…#17
Column order issue on select statement - task - https://app.clickup.c…#17Girish B (Girish2402) wants to merge 2 commits intomasterfrom
Conversation
| query = build_query() | ||
| @results = @model.find_by_sql([query, @bind_variables]) # Execute Sql Query | ||
| query = to_sql | ||
| @results = @model.connection.select_all(query).as_json # Execute Sql Query |
There was a problem hiding this comment.
Girish B (@Girish2402) Do you have any test result to prove that it is not changing output, In my understanding select_all returns array of hash or json and find_by_sql returns model objects.
There was a problem hiding this comment.
Girish B (@Girish2402) Can you also explain why do you need this change? what is the use case?
There was a problem hiding this comment.
Vishal Zambre (@vishalzambre)
We rely on the order that we pass on the select statements in query for CSV column order but it's not getting the same order.
Task - https://app.clickup.com/t/1c5cry4
There was a problem hiding this comment.
Hi Vishal Zambre (@vishalzambre) Nilesh Navale (@NileshN)
I add test cases for association(include) but its fails.
Association is failing for these changes.
https://github.com/patterninc/query_helper#associations
Do not merge changes.
Test results:
Failure/Error: ActiveRecord::Associations::Preloader.new.preload(payload, associations)
NoMethodError:
undefined method `_reflect_on_association' for Hash:Class
Vishal Zambre (vishalzambre)
requested review from
Nilesh Navale (NileshN) and
Matt Smith (smithworx)
3 participants
Description
find_by_sql doesn't preserve the column order.
reference link - https://stackoverflow.com/questions/209558/column-order-of-results-from-rails-activerecord-find-by-sql-call
Clickup Story
https://app.clickup.com/t/1c5cry4
Deployment Details
Standard process
Reminders