fix(ResponsiveActions): Disable kebab when all actions are disabled#928
Open
rhamilto wants to merge 1 commit intopatternfly:mainfrom
Open
fix(ResponsiveActions): Disable kebab when all actions are disabled#928rhamilto wants to merge 1 commit intopatternfly:mainfrom
rhamilto wants to merge 1 commit intopatternfly:mainfrom
Conversation
Fixes patternfly#927 - Uses OverflowMenuContext to access isBelowBreakpoint state - Kebab disabled state is now responsive to viewport width: - Above breakpoint: disabled if all regular items are disabled - Below breakpoint: disabled if all items (pinned + regular) are disabled - Created ResponsiveActionsDropdown component to access context - Tracks disabled state separately for pinned vs regular items - Added comprehensive test coverage for all scenarios - Fully backward compatible (no breaking changes)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #927
This PR implements the PatternFly design guideline that a kebab menu should be disabled when all of its actions are disabled.
Changes
Implementation
Testing
Behavior
Before
After
Backward Compatibility
✅ Fully backward compatible
Screenshots/Examples
The kebab will now properly show as disabled when appropriate, improving accessibility and UX.
Checklist