Skip to content

feat(BulkSelect): disable Select none option when no rows are selected #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karelhala merged 2 commits into from
Apr 29, 2026
Merged

feat(BulkSelect): disable Select none option when no rows are selected #914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29acb17
feat(BulkSelect): disable Select none when no rows are selected
raswonders Apr 22, 2026
09a5d61
test(BulkSelect): add unit tests for disabling Select none option
raswonders Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions packages/module/src/BulkSelect/BulkSelect.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,4 +100,40 @@ describe('BulkSelect component', () => {
expect(screen.getByText('Sélectionner la page (5)')).toBeInTheDocument();
expect(screen.getByText('Tout sélectionner (10)')).toBeInTheDocument();
});

test('should disable Select none when nothing is selected', async () => {
const user = userEvent.setup();
render(
<BulkSelect
canSelectAll
pageCount={5}
totalCount={10}
selectedCount={0}
pageSelected={false}
pagePartiallySelected={false}
onSelect={() => null}
/>
);

await user.click(screen.getByLabelText('Bulk select toggle'));
expect(screen.getByRole('menuitem', { name: 'Select none (0)' })).toBeDisabled();
});

test('should enable Select none when at least one row is selected', async () => {
const user = userEvent.setup();
render(
<BulkSelect
canSelectAll
pageCount={5}
totalCount={10}
selectedCount={1}
pageSelected={false}
pagePartiallySelected={true}
onSelect={() => null}
/>
);

await user.click(screen.getByLabelText('Bulk select toggle'));
expect(screen.getByRole('menuitem', { name: 'Select none (0)' })).not.toBeDisabled();
});
});
9 changes: 7 additions & 2 deletions packages/module/src/BulkSelect/BulkSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,12 @@ export const BulkSelect: FC<BulkSelectProps> = ({
const splitButtonDropdownItems = useMemo(
() => (
<>
<DropdownItem ouiaId={`${ouiaId}-select-none`} value={BulkSelectValue.none} key={BulkSelectValue.none}>
<DropdownItem
ouiaId={`${ouiaId}-select-none`}
value={BulkSelectValue.none}
key={BulkSelectValue.none}
isDisabled={selectedCount === 0}
>
{selectNoneLabel}
</DropdownItem>
{isDataPaginated && (
Expand All @@ -103,7 +108,7 @@ export const BulkSelect: FC<BulkSelectProps> = ({
)}
</>
),
[ isDataPaginated, canSelectAll, ouiaId, selectNoneLabel, selectPageLabel, selectAllLabel, pageCount, totalCount ]
[ isDataPaginated, canSelectAll, ouiaId, selectNoneLabel, selectPageLabel, selectAllLabel, pageCount, totalCount, selectedCount ]
);

const selectedLabelText = selectedLabel(selectedCount);
Expand Down
Loading