Added code for npm publishing via semantic release.#15
Open
Conversation
dlabaj
changed the title
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: "lts/*" |
There was a problem hiding this comment.
curious why you went with this here instead of 20?
| "@semantic-release/github" | ||
| ], | ||
| "dryRun": true | ||
| } |
There was a problem hiding this comment.
this file will need some changes if we want to have the standard releases be -prerelease like in our other repos, but if we don't care about that ignore this comment.
Comment on lines
+25
to
+26
| "assets": ["CHANGELOG.md", "package.json"], | ||
| "message": "chore(release): ${nextRelease.version} [skip ci]\n\n${nextRelease.notes}" |
There was a problem hiding this comment.
I'm curious what prompted you to add these release commits, but that isn't to say I'm against it.
| @@ -1,2 +1,2 @@ | |||
| { | |||
| "name": "patternfly-cli", | |||
There was a problem hiding this comment.
Also do you want to change this to @patternfly/patternfly-cli so that it releases under the PF npm org?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added code to perform npm publish for the cli repo via semantic release. Close issue #14