Fix Q_heat always zero for isothermal cells; add unit tests#9
Merged
DavidMStraub merged 2 commits intopathsim:masterfrom May 5, 2026
Merged
Conversation
- Enable 'calculate heat source for isothermal models' option for CellElectrical and CellCoSimElectrical via _thermal_extra_options class variable, wired into both _CellBase and _CoSimCellBase - Fix _CoSimCellBase._initial_outputs: bm.y0 is None in PyBaMM 26.x before the first step; return zero-filled placeholder with SOC set - Pass save=False to pybamm.Simulation.step() to prevent unbounded memory growth on long co-sim runs - Add tests: Q_heat nonzero during discharge, temperature input effectiveness — for all four cell classes
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Q_heat being identically zero for the isothermal PyBaMM-backed electrical cell blocks by enabling PyBaMM’s heat-source calculation for isothermal models, and adds integration tests to prevent regressions.
Changes:
- Pass an additional PyBaMM model option for isothermal cells to compute heat-source terms (
calculate heat source for isothermal models). - Add integration tests asserting (a)
Q_heatis non-zero under discharge and (b) temperature inputs materially affect voltage/temperature outputs across electrical/electrothermal + co-sim variants.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/pathsim_batt/cells/pybamm_cell.py |
Adds support for extra PyBaMM thermal options and enables isothermal heat-source calculation for electrical cell defaults. |
tests/cells/test_pybamm_cell.py |
Adds regression tests covering non-zero heat generation and temperature-input coupling behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DavidMStraub
force-pushed
the
fix/isothermal-heat-source
branch
2 times, most recently
from
05a2ee6 to
ee3f7cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out the
CellEletricalwasn't actually working as PyBaMM wasn't computing the heat source term.Fixed, plus added tests that would have detected it...