Open
Conversation
Place block type definitions in `pub.oxa.blocks.defs` and generate them at `lexicon/blocks/defs.json` instead of nesting them under the document lexicon. Update generated refs, conversion code, tests, docs, and examples to use the new block namespace.\n\nThis makes the block schema easier to reuse from other document lexicons rather than tying it to `pub.oxa.document.document`. For example, `pub.oxa.blocks.defs#block` can be referenced from an open `content` property in another record schema such as `site.standard.document`.\n\nCo-authored-by: Stencila <47797644+stencila[bot]@users.noreply.github.com>
|
Contributor
|
Curvenote Preview
|
Simplify the document record NSID from `pub.oxa.document.document` to `pub.oxa.document`, consistent with the naming convention used by `site.standard.document` and others. This is possible now that block type definitions have been moved to their own `pub.oxa.blocks.defs` namespace. Co-authored-by: Stencila <47797644+stencila[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Place block type definitions in
pub.oxa.blocks.defsand generate them atlexicon/blocks/defs.jsoninstead of nesting them under the document lexicon. Update generated refs, conversion code, tests, docs, and examples to use the new block namespace.This makes the block schema easier to reuse from other document lexicons rather than tying it to
pub.oxa.document. For example,pub.oxa.blocks.defs#blockcan be referenced from an opencontentproperty in another record schema such assite.standard.document.By moving blocks out of the document schema it also allows us to simplify the main document id from
pub.oxa.document.documenttopub.oxa.document