net/frr: add BFD strict mode for BGP neighbors#5315
net/frr: add BFD strict mode for BGP neighbors#5315r3m8 wants to merge 2 commits intoopnsense:masterfrom
Conversation
| neighbor {{ neighbor.address }} bfd | ||
| {% endif %} | ||
| {% if neighbor.bfd_strict|default('') == '1' %} | ||
| neighbor {{ neighbor.address }} bfd strict |
There was a problem hiding this comment.
I would expect strict is an add-on to the neighbor .. bfd line above, in which case this probably should merge in there (e.g. {{if neighbor.bfd_strict|default('') == '1' %}strict{{ endif }} at the end
There was a problem hiding this comment.
frr works fine with this duplicate lines, but it would look cleaner on a single line I agree.
|
Ready for another review |
|
I won't review this PR, but I want to have docs updates as requirement too before any merging here. https://github.com/opnsense/docs/blob/master/source/manual/dynamic_routing.rst check out this example: |
Thanks for all the information ! I'll do that for other open PRs and maybe new ones in the future. |
| formatTokenizersUI(); | ||
| $('.selectpicker').selectpicker('refresh'); | ||
| updateServiceControlUI('quagga'); | ||
| $('#neighbor\\.bfd').trigger('change'); |
There was a problem hiding this comment.
I expect you don't need this as the change event is triggered on all inputs on load anyway.
3 participants
Important notices
Before you submit a pull request, we ask you kindly to acknowledge the following:
AI tools were used to create at least part of the code submitted herewith.Related issue
#5314
Describe the problem
The OPNsense FRR plugin currently lacks support for BFD Strict Mode in BGP neighbor configuration. This FRR feature ensures BGP sessions are only established when the underlying BFD session is up, preventing routing issues when physical connectivity is lost but BGP sessions remain artificially active.
Describe the proposed solution
This PR adds a "BFD Strict Mode" checkbox to the BGP neighbor configuration. The checkbox is hidden when BFD is disabled and appears when BFD is enabled, following the same pattern as OSPFv3's "Advertise Default Gateway" feature (I'm not sure this is the best way to do it, please let me know if not).
docs.frrouting.org/en/latest/bfd.html