dashboard: ui improvements of the Services widget#9608
dashboard: ui improvements of the Services widget#9608swhite2 merged 8 commits intoopnsense:masterfrom
Conversation
|
@sopex thanks! The schedule for 26.1 is a bit right. I need to wait for merge until stable/26.1 is branched which should happen early next week. Cheers, |
Sure. Let me know if you have any changes in mind. I understand that these days are difficult! Keep up the awesome work! |
swhite2
left a comment
There was a problem hiding this comment.
Don't think this needs to be a BaseTableWidget anymore?
|
Franco also mentioned the idea of placing the name on the left side of the tile, the buttons on the right side and letting the tile background color reflect the current status, instead of the "play" button. The tooltip should then be triggered on the entire tile. |
|
I personally like them being centered. Another idea would be eliminating the buttons. Have the tile be green for On/ Blue for restarting/ red for off. And make the whole tile a button. But you are losing the restart functionality for the ones that support turning off. |
|
But honestly, I like the result of this PR. It fits with the whole aesthetic much more, while modernizing the old list and making it look like a control panel. |
|
The WebGUI tile seems a bit off here, any chance this can be equally sized? |
I suppose it could. It just resizes because it's the last one, and there is space for it. If you prefer it to leave empty space, I don't believe this would be a problem. |
Let's go for that then. |
|
Option 1:
Option 2:
Sure about option 1? @swhite2 |
|
@swhite2 If you have an input here too. |
|
Yes, option 1 looks better. Testing this it seems the grid of controls isn't scaling the widget. when made small enough, you can only see the first column. |
Ok, I am 50-50
Do you want it to rescale or just disable the resizing? It's not like it was resizing great before, and 3 columns seem a good idea. |
|
@swhite2 This way it works much better on mobile devices too. |
|
@swhite2 Hi Stephan, kind reminder. |
|
@sopex Thoughts on aligning the buttons consistently?
|
|
@swhite2 If this counts, then yes. You break them to two rows, the left row is aligned right with a 10px padding and the right row is aligned left.
|
I think this is a bit easier on the eyes, let's go for that. |
Done! |
|
Looks good, thanks @sopex :) |







A good start.
Closes: #7887