Skip to content

dashboard: ui improvements of the Services widget#9608

Merged
swhite2 merged 8 commits intoopnsense:masterfrom
sopex:services
Apr 17, 2026
Merged

dashboard: ui improvements of the Services widget#9608
swhite2 merged 8 commits intoopnsense:masterfrom
sopex:services

Conversation

@sopex
Copy link
Copy Markdown
Member

@sopex sopex commented Jan 9, 2026

A good start.
Closes: #7887

Screenshot 2026-01-09 182920

@fichtner fichtner self-assigned this Jan 16, 2026
@fichtner
Copy link
Copy Markdown
Member

@sopex thanks! The schedule for 26.1 is a bit right. I need to wait for merge until stable/26.1 is branched which should happen early next week.

Cheers,
Franco

@sopex
Copy link
Copy Markdown
Member Author

sopex commented Jan 16, 2026

@sopex thanks! The schedule for 26.1 is a bit right. I need to wait for merge until stable/26.1 is branched which should happen early next week.

Cheers, Franco

Sure. Let me know if you have any changes in mind. I understand that these days are difficult!

Keep up the awesome work!

Copy link
Copy Markdown
Member

@swhite2 swhite2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think this needs to be a BaseTableWidget anymore?

@swhite2 swhite2 self-assigned this Jan 19, 2026
@swhite2
Copy link
Copy Markdown
Member

swhite2 commented Jan 19, 2026

Franco also mentioned the idea of placing the name on the left side of the tile, the buttons on the right side and letting the tile background color reflect the current status, instead of the "play" button. The tooltip should then be triggered on the entire tile.

@sopex
Copy link
Copy Markdown
Member Author

sopex commented Jan 19, 2026

I personally like them being centered.

Another idea would be eliminating the buttons. Have the tile be green for On/ Blue for restarting/ red for off. And make the whole tile a button. But you are losing the restart functionality for the ones that support turning off.

@sopex
Copy link
Copy Markdown
Member Author

sopex commented Jan 19, 2026

But honestly, I like the result of this PR. It fits with the whole aesthetic much more, while modernizing the old list and making it look like a control panel.

@sopex
Copy link
Copy Markdown
Member Author

sopex commented Mar 24, 2026

@fichtner @swhite2 Any new thoughts here?

@swhite2
Copy link
Copy Markdown
Member

swhite2 commented Mar 24, 2026

The WebGUI tile seems a bit off here, any chance this can be equally sized?

@sopex
Copy link
Copy Markdown
Member Author

sopex commented Mar 24, 2026

The WebGUI tile seems a bit off here, any chance this can be equally sized?

I suppose it could. It just resizes because it's the last one, and there is space for it. If you prefer it to leave empty space, I don't believe this would be a problem.

@swhite2
Copy link
Copy Markdown
Member

swhite2 commented Mar 24, 2026

The WebGUI tile seems a bit off here, any chance this can be equally sized?

I suppose it could. It just resizes because it's the last one, and there is space for it. If you prefer it to leave empty space, I don't believe this would be a problem.

Let's go for that then.

@sopex
Copy link
Copy Markdown
Member Author

sopex commented Mar 24, 2026

Option 1:

Screenshot 2026-03-24 174944 Screenshot 2026-03-24 174902

Option 2:

Screenshot 2026-03-24 175001 Screenshot 2026-03-24 174122

Sure about option 1? @swhite2

@sopex sopex changed the title Services widget dashboard: ui improvements of the Services widget Mar 25, 2026
@sopex
Copy link
Copy Markdown
Member Author

sopex commented Mar 30, 2026

@swhite2 If you have an input here too.

@swhite2
Copy link
Copy Markdown
Member

swhite2 commented Mar 31, 2026

Yes, option 1 looks better.

Testing this it seems the grid of controls isn't scaling the widget. when made small enough, you can only see the first column.

@sopex
Copy link
Copy Markdown
Member Author

sopex commented Mar 31, 2026

Yes, option 1 looks better.

Ok, I am 50-50

Testing this it seems the grid of controls isn't scaling the widget. when made small enough, you can only see the first column.

Do you want it to rescale or just disable the resizing? It's not like it was resizing great before, and 3 columns seem a good idea.

@sopex
Copy link
Copy Markdown
Member Author

sopex commented Mar 31, 2026

@swhite2 This way it works much better on mobile devices too.

@sopex sopex requested a review from swhite2 April 1, 2026 09:21
@sopex
Copy link
Copy Markdown
Member Author

sopex commented Apr 17, 2026

@swhite2 Hi Stephan, kind reminder.

Comment thread src/opnsense/www/js/widgets/Services.js Outdated
@swhite2
Copy link
Copy Markdown
Member

swhite2 commented Apr 17, 2026

@sopex Thoughts on aligning the buttons consistently?

image

@sopex
Copy link
Copy Markdown
Member Author

sopex commented Apr 17, 2026

@swhite2 If this counts, then yes. You break them to two rows, the left row is aligned right with a 10px padding and the right row is aligned left.

image

@swhite2
Copy link
Copy Markdown
Member

swhite2 commented Apr 17, 2026

@swhite2 If this counts, then yes. You break them to two rows, the left row is aligned right with a 10px padding and the right row is aligned left.

I think this is a bit easier on the eyes, let's go for that.

@sopex
Copy link
Copy Markdown
Member Author

sopex commented Apr 17, 2026

I think this is a bit easier on the eyes, let's go for that.

Done!

@sopex sopex marked this pull request as draft April 17, 2026 13:55
@sopex sopex marked this pull request as ready for review April 17, 2026 14:00
Comment thread src/opnsense/www/js/widgets/Services.js
Copy link
Copy Markdown
Member

@swhite2 swhite2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me apart from the small nitpick above. There's something to be said still about the spacing in the tiles, but I'll discuss that with @fichtner

@sopex
Copy link
Copy Markdown
Member Author

sopex commented Apr 17, 2026

Looks good to me apart from the small nitpick above. There's something to be said still about the spacing in the tiles, but I'll discuss that with @fichtner

I think with 9c99154 this is almost perfect. 1.2 or 1.25 should do the trick.

image

@swhite2 swhite2 merged commit 36158f6 into opnsense:master Apr 17, 2026
@swhite2
Copy link
Copy Markdown
Member

swhite2 commented Apr 17, 2026

Looks good, thanks @sopex :)

@sopex sopex deleted the services branch April 17, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

system: compact services widget

3 participants