Open
Conversation
AdSchellevis
reviewed
Apr 4, 2026
AdSchellevis
added a commit
that referenced
this pull request
Apr 6, 2026
Although this isn't a full implementation yet, it can help callers that need to access the menu system. In the long run it might be practical if this class would also construct the menu system, so we can add some flexibility there.
Uses client-side DOM for determining log endpoints, doesn't require any default target access, allows options for severity and search filter and variable log lines to show, which are displayed in summary in widget, and uses true log tailing plus backfill
swhite2
reviewed
Apr 7, 2026
| <severityinformational>Informational</severityinformational> | ||
| <severitydebug>Debug</severitydebug> | ||
| <searchfilter>Search filter</searchfilter> | ||
| <searchfilterplaceholder>dhcp error</searchfilterplaceholder> |
Member
There was a problem hiding this comment.
I see what you're trying to do here, but perhaps it looks a little out of place. Maybe just nothing? Not sure myself
Contributor
Author
There was a problem hiding this comment.
The aim was simply to show format of the filter text (space separated words). I'm not wedded to the specific content. But having nothing for a placeholder will not give any guidance. Afaik help text is not available in widget options. And I didn't want to clutter the heading with format guidance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context and approach are detailed in #9684
Closes #9684
Depends on 1216d60 and 7cfb03b