System: Routing: Changed disable option to enable#10027
Merged
fichtner merged 11 commits intoopnsense:masterfrom Apr 13, 2026
Merged
System: Routing: Changed disable option to enable#10027fichtner merged 11 commits intoopnsense:masterfrom
fichtner merged 11 commits intoopnsense:masterfrom
Conversation
fichtner
reviewed
Mar 24, 2026
TomWalraven
force-pushed
the
route-disable-to-enable
branch
from
35ea233 to
bb11f1d
Compare
fichtner
reviewed
Mar 27, 2026
fichtner
reviewed
Mar 27, 2026
TomWalraven
force-pushed
the
route-disable-to-enable
branch
from
3502f90 to
988fc12
Compare
fichtner
reviewed
Apr 7, 2026
fichtner
reviewed
Apr 7, 2026
fichtner
reviewed
Apr 7, 2026
fichtner
reviewed
Apr 7, 2026
fichtner
added a commit
that referenced
this pull request
Apr 7, 2026
Member
|
I did a quick audit of where else this is used and cleaned this up faa7dab where necessary.. I think folding the compat into get_staticroutes() is a good way forward that minimizes impact :) |
TomWalraven
force-pushed
the
route-disable-to-enable
branch
2 times, most recently
from
72574a1 to
3d4c41a
Compare
fichtner
reviewed
Apr 9, 2026
fichtner
approved these changes
Apr 10, 2026
Member
fichtner
left a comment
fichtner
left a comment
There was a problem hiding this comment.
this turned out better than I could hope for. very nicely done 👍
fichtner
reviewed
Apr 10, 2026
swhite2
requested changes
Apr 10, 2026
Comment on lines
+126
to
+139
| public function togglerouteAction($uuid, $enabled = null) | ||
| { | ||
| $result = array("result" => "failed"); | ||
| if ($this->request->isPost() && $uuid != null) { | ||
| $node = $this->getModel()->getNodeByReference('route.' . $uuid); | ||
| if ($node != null) { | ||
| if ($disabled == '0' || $disabled == '1') { | ||
| $node->disabled = (string)$disabled; | ||
| } elseif ((string)$node->disabled == '1') { | ||
| $node->disabled = '0'; | ||
| if ($enabled == '0' || $enabled == '1') { | ||
| $node->enabled = (string)$enabled; | ||
| } elseif ((string)$node->enabled == '1') { | ||
| $node->enabled = '0'; | ||
| } else { | ||
| $node->disabled = '1'; | ||
| $node->enabled = '1'; | ||
| } | ||
| $result['result'] = (string)$node->disabled == '1' ? 'Disabled' : 'Enabled'; | ||
| $result['result'] = (string)$node->enabled == '1' ? 'Enabled' : 'Disabled'; |
Member
There was a problem hiding this comment.
I think this can use toggleBase() now. In fact, this allows the front-end to use multi-select as well (batched toggle):
({selection: true})
Make sure to set batchDelete: false as well, as the delrouteAction doesn't account for multiple UUIDs.
Contributor
Author
There was a problem hiding this comment.
Applied in 0f041ae. Thanks for the suggestion 😄
Member
There was a problem hiding this comment.
If toggleBase() is used, this comment can go as well.
Co-authored-by: Franco Fichtner <franco@lastsummer.de>
…led options in get_staticroutes()
TomWalraven
force-pushed
the
route-disable-to-enable
branch
from
daedcf7 to
0f041ae
Compare
Member
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the disabled option to enabled in system routes configuration.
Closes: #8780