cloudflared: support multiple upstream interfaces in init script#29117
Open
kouhei-ioroi wants to merge 1 commit intoopenwrt:masterfrom
Open
cloudflared: support multiple upstream interfaces in init script#29117kouhei-ioroi wants to merge 1 commit intoopenwrt:masterfrom
kouhei-ioroi wants to merge 1 commit intoopenwrt:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support for restarting cloudflared when one or more configured upstream network interfaces come up, instead of being hardcoded to wan.
Changes:
- Load UCI config in
service_triggers()and dynamically register interface-up triggers for configured interfaces - Add a default
list interface 'wan'to the samplecloudflared.config
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| net/cloudflared/files/cloudflared.init | Registers procd interface triggers based on configured interface list |
| net/cloudflared/files/cloudflared.config | Adds default interface list entry (wan) for interface-up detection |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kouhei-ioroi
force-pushed
the
feature_cloudflared_multiple_upstream_interface
branch
from
11b5601 to
1415edd
Compare
1715173329
reviewed
Apr 13, 2026
| @@ -1,6 +1,6 @@ | |||
|
|
|||
Member
There was a problem hiding this comment.
please leave this blank line as-is and bump PKG_RELEASE in Makefile
|
|
||
| config cloudflared 'config' | ||
| option enabled '0' | ||
| list interface 'wan' |
kouhei-ioroi
force-pushed
the
feature_cloudflared_multiple_upstream_interface
branch
2 times, most recently
from
d384c0e to
13a6289
Compare
kouhei-ioroi
force-pushed
the
feature_cloudflared_multiple_upstream_interface
branch
from
52b0f98 to
65a7a66
Compare
support multiple upstream interfaces in config. Signed-off-by: kouhei-ioroi <kouhei@ioroi.group>
kouhei-ioroi
force-pushed
the
feature_cloudflared_multiple_upstream_interface
branch
from
65a7a66 to
c4d161e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @1715173329
(You can find this by checking the history of the package
Makefile.)Description:
This pull request implements the ability to restart
cloudflaredservice in the event of an upstream interface other than the "wan" defined by default, as well as multiple upstream interfaces.The changes include:
🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am(e.g., subject line, commit description, etc.)
We must try to upstream patches to reduce maintenance burden.