Fix plugin config sporadic and fix proxy test#4188
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Hugging Face pull/clone timeout test to behave deterministically across environments by controlling proxy usage and the remote endpoint used during the clone attempt.
Changes:
- Forces a direct (no-proxy) connection in
TestInvalidProxyTimeoutso libgit2’s connect-timeout setting is applied. - Overrides
HF_ENDPOINTto an unroutable TEST-NET-1 IP to avoid relying on realhuggingface.coconnectivity for the test outcome.
dtrawins
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary
Proxy Issue #4172
Detect if proxy is set - norma path
Proxy not set - test timeout on HF_ENDPOINT
Fix sporadic Windows segfault in loadModel with numeric plugin config
Root cause fix: openvinotoolkit/openvino#35714
OVMS passes plugin_config_t (std::map<std::string, ov::Any>) to
compile_model, but ov::Any values for numeric properties like NUM_STREAMS
can carry either int64_t or std::string depending on the code path.
OpenVINO's CPU plugin unconditionally calls val.asstd::string() on all
properties, triggering an unsafe iostream conversion when the value is
numeric — causing sporadic memory corruption and segfault on Windows.
Add a typed normalization table in prepareDefaultPluginConfig that converts
known numeric/bool properties (NUM_STREAMS, INFERENCE_NUM_THREADS,
AUTO_BATCH_TIMEOUT, ENABLE_CPU_PINNING) from string to their native type
before compile_model is called. String-typed properties like PERFORMANCE_HINT
are untouched. Normalization also recurses into nested DEVICE_PROPERTIES maps.
🧪 Checklist
``