[DNM] [openshift_setup] Refactor registries patch to use Ansible modules instead of ansible.builtin.shell with oc patch.#3767
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ca2ae5211d0d421085a5d6fc89d4eb1e ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 05m 08s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a4d8585d87934ab1ade71317359c59c0 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 30m 39s |
nemarjan
force-pushed
the
refactor/allowed-registries-json-patch
branch
from
959c902 to
8e4c68c
Compare
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c5b89609ac79444782200029820a08d4 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 18m 30s |
|
recheck |
nemarjan
force-pushed
the
refactor/allowed-registries-json-patch
branch
from
8e4c68c to
b49bedc
Compare
|
recheck |
nemarjan
force-pushed
the
refactor/allowed-registries-json-patch
branch
from
b49bedc to
2606921
Compare
|
recheck |
nemarjan
force-pushed
the
refactor/allowed-registries-json-patch
branch
from
2606921 to
1aede1f
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/379379b453214f76a60e06699402b6fd ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 15m 39s |
| } | ||
| } | ||
| }' image.config.openshift.io/cluster | ||
| delegate_to: localhost |
There was a problem hiding this comment.
I think if you do delegate_to: controller and kubeconfig: "{{ cifmw_openshift_kubeconfig }}" should work
nemarjan
force-pushed
the
refactor/allowed-registries-json-patch
branch
6 times, most recently
from
2e68c4b to
ec35005
Compare
…stead of ansible.builtin.shell with oc patch. - Refactoring task "Add additional allowed registries" as specified here ( https://github.com/openstack-k8s-operators/ci-framework/pull/3712/changes#r2858651309*) and using Ansible module to patch. - Merging tasks "Patch the image.config.openshift.io resource to include insecure registry" and "Patch the image.config.openshift.io resource to allow registries" in to a single task, replacing use of ansible.builtin.shell with use of Ansible module. Signed-off-by: nemarjan <nemarjan@redhat.com>
nemarjan
force-pushed
the
refactor/allowed-registries-json-patch
branch
from
ec35005 to
bd5104c
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0ce8702a03534ea78fc6bb990deff206 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 10m 14s |
3 participants
Refactoring task "Add additional allowed registries" as specified here ( https://github.com/openstack-k8s-operators/ci-framework/pull/3712/changes#r2858651309*) and using Ansible module to patch.
Merging tasks "Patch the image.config.openshift.io resource to include insecure registry" and "Patch the image.config.openshift.io resource to allow registries" in to a single task, replacing use of ansible.builtin.shell with use of Ansible module.