-
Notifications
You must be signed in to change notification settings - Fork 227
USHIFT-6547: Add RHEL 10 CI lane #6318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,34 @@ | ||||||||||||||||||
| FROM localhost/rhel102-bootc-source:latest | ||||||||||||||||||
|
|
||||||||||||||||||
| # The qemu-guest-agent is used in offline tests | ||||||||||||||||||
| RUN dnf install -y qemu-guest-agent && \ | ||||||||||||||||||
| systemctl enable qemu-guest-agent && \ | ||||||||||||||||||
| dnf clean all | ||||||||||||||||||
|
|
||||||||||||||||||
| # Override the default qemu-ga service configuration on the guest to allow all RPCs. | ||||||||||||||||||
| # BLOCK_RPCS is a deny-list of qemu-guest-agent RPCs to block, such as file read/write, process execution, etc. By | ||||||||||||||||||
| # default, all RPCs are blocked. | ||||||||||||||||||
| # FREEZE_HOOK_PATHNAME is the dir-path containing hook scripts. This override does not change the default value. | ||||||||||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Minor typo in comment. Comment says "FREEZE_HOOK_PATHNAME" but the actual variable written on line 18 is "FSFREEZE_HOOK_PATHNAME". ✏️ Suggested fix-# FREEZE_HOOK_PATHNAME is the dir-path containing hook scripts. This override does not change the default value.
+# FSFREEZE_HOOK_PATHNAME is the dir-path containing hook scripts. This override does not change the default value.📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||
| # These scripts are executed before or after guest image snapshot ops ("freezing" and "thawing" in libvirt speak). | ||||||||||||||||||
| # No hooks are installed by default. | ||||||||||||||||||
| RUN printf '\ | ||||||||||||||||||
| \# This is a systemd environment file, not a shell script.\n\ | ||||||||||||||||||
| \# It provides settings for "/lib/systemd/system/qemu-guest-agent.service".\n\ | ||||||||||||||||||
| BLOCK_RPCS=\n\ | ||||||||||||||||||
| FSFREEZE_HOOK_PATHNAME=/etc/qemu-ga/fsfreeze-hook\n' > /etc/sysconfig/qemu-ga | ||||||||||||||||||
|
|
||||||||||||||||||
| # Embed images based on contents of release-info RPMs | ||||||||||||||||||
| COPY --chmod=755 ./bootc-images/microshift-copy-images.sh /usr/bin/microshift-copy-images | ||||||||||||||||||
| RUN --mount=type=secret,id=pullsecret,dst=/run/secrets/pull-secret.json \ | ||||||||||||||||||
| images="$(jq -r ".images[]" /usr/share/microshift/release/release-"$(uname -m)".json)" ; \ | ||||||||||||||||||
| images="${images} quay.io/microshift/busybox:1.36" ; \ | ||||||||||||||||||
| IMAGE_PULL_LIST="${images}" /usr/bin/microshift-copy-images pull | ||||||||||||||||||
|
Comment on lines
+22
to
+25
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
/bin/sh -c 'images=$(false); printf "assignment_status=%s\n" "$?"; images="${images} quay.io/microshift/busybox:1.36"; printf "continued=%s\n" "$images"; true'Repository: openshift/microshift Length of output: 126 Use With Suggested fix RUN --mount=type=secret,id=pullsecret,dst=/run/secrets/pull-secret.json \
- images="$(jq -r ".images[]" /usr/share/microshift/release/release-"$(uname -m)".json)" ; \
- images="${images} quay.io/microshift/busybox:1.36" ; \
+ images="$(jq -r '.images[]' "/usr/share/microshift/release/release-$(uname -m).json")" && \
+ images="${images} quay.io/microshift/busybox:1.36" && \
IMAGE_PULL_LIST="${images}" /usr/bin/microshift-copy-images pull📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||
|
|
||||||||||||||||||
| # Install a systemd drop-in unit to address the problem with image upgrades | ||||||||||||||||||
| # overwriting the container images in additional store. The workaround is to | ||||||||||||||||||
| # copy the images from the pre-loaded to the main container storage. | ||||||||||||||||||
| # In this case, it is not necessary to update /etc/containers/storage.conf with | ||||||||||||||||||
| # the additional store path. | ||||||||||||||||||
| # See https://issues.redhat.com/browse/RHEL-75827 | ||||||||||||||||||
| RUN mkdir -p /usr/lib/systemd/system/microshift.service.d | ||||||||||||||||||
| COPY --chmod=644 ./bootc-images/microshift-copy-images.conf /usr/lib/systemd/system/microshift.service.d/microshift-copy-images.conf | ||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| localhost/rhel102-bootc-source-isolated:latest | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Keep the Line 1 points a 🤖 Prompt for AI Agents |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| {{- if env.Getenv "BREW_LREL_RELEASE_VERSION" "" -}} | ||
| localhost/rhel102-bootc-brew-lrel-optional:latest | ||
| {{- end }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not duplicate the code. Deternine the
${os}variable and let's have the same build command sequence.