OCPBUGS-81161: [release-4.19] fix(cpo): Don't remove HCP Ingress from routes when CapabilityRoute is disabled

[arolika]

What this PR does / why we need it:

This is a backport PR to release-4.19 branch. I'm opening this because the [cherrypick PR had merge conflicts.](#8083)
[Original PR can be found here.](#8001)

On IBM Cloud the servicePublishingStrategy: Route can't assume that the management cluster is an OCP cluster, because it still has vanilla k8s management clusters.
When running on vanilla Kubernetes on IBM Cloud (which doesn't have Route CRDs), the operator crashes during reconciliation when attempting to list Route resources.
HyperShift on IBM Cloud should work on both OpenShift and vanilla Kubernetes (IBM Cloud) management clusters, gracefully handling the absence of optional APIs like Route.

The fix is an extra check in the removeHCPIngressFromRoutes() function to return early if the management cluster has no Route capability.

Which issue(s) this PR fixes:

Fixes #OCPBUGS-78778

Special notes for your reviewer:

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

[openshift-ci-robot]

@arolika: This pull request references Jira Issue OCPBUGS-80950, which is invalid:

• expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.20.z" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
• expected dependent Jira Issue OCPBUGS-78933 to target a version in 4.20.0, 4.20.z, but it targets "4.21.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

OCPBUGS-78778: fix(cpo): Don't remove HCP Ingress from routes when CapabilityRoute is disabled - 4.19 backport

What this PR does / why we need it:

This is a backport PR to release-4.19 branch. I'm opening this because the [cherrypick PR had merge conflicts.](#8083)
[Original PR can be found here.](#8001)

On IBM Cloud the servicePublishingStrategy: Route can't assume that the management cluster is an OCP cluster, because it still has vanilla k8s management clusters.
When running on vanilla Kubernetes on IBM Cloud (which doesn't have Route CRDs), the operator crashes during reconciliation when attempting to list Route resources.
HyperShift on IBM Cloud should work on both OpenShift and vanilla Kubernetes (IBM Cloud) management clusters, gracefully handling the absence of optional APIs like Route.

The fix is an extra check in the removeHCPIngressFromRoutes() function to return early if the management cluster has no Route capability.

Which issue(s) this PR fixes:

Fixes #OCPBUGS-78778

Special notes for your reviewer:

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

• do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2fb02fc5-7a81-4ba0-ae45-7c51826db22d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

Hi @arolika. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[arolika]

/retitle [release-4.19] fix(cpo): Don't remove HCP Ingress from routes when CapabilityRoute is disabled

[openshift-ci]

@arolika: Re-titling can only be requested by trusted users, like repository collaborators.

Details

In response to this:

/retitle [release-4.19] fix(cpo): Don't remove HCP Ingress from routes when CapabilityRoute is disabled

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[matlaj]

/retitle [release-4.19] fix(cpo): Don't remove HCP Ingress from routes when CapabilityRoute is disabled

[openshift-ci-robot]

@arolika: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

What this PR does / why we need it:

This is a backport PR to release-4.19 branch. I'm opening this because the [cherrypick PR had merge conflicts.](#8083)
[Original PR can be found here.](#8001)

On IBM Cloud the servicePublishingStrategy: Route can't assume that the management cluster is an OCP cluster, because it still has vanilla k8s management clusters.
When running on vanilla Kubernetes on IBM Cloud (which doesn't have Route CRDs), the operator crashes during reconciliation when attempting to list Route resources.
HyperShift on IBM Cloud should work on both OpenShift and vanilla Kubernetes (IBM Cloud) management clusters, gracefully handling the absence of optional APIs like Route.

The fix is an extra check in the removeHCPIngressFromRoutes() function to return early if the management cluster has no Route capability.

Which issue(s) this PR fixes:

Fixes #OCPBUGS-78778

Special notes for your reviewer:

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[arolika]

/jira cherry-pick OCPBUGS-80950

[openshift-ci-robot]

@arolika: Jira Issue OCPBUGS-80950 has been cloned as Jira Issue OCPBUGS-81161. Will retitle bug to link to clone.
/retitle OCPBUGS-81161: [release-4.19] fix(cpo): Don't remove HCP Ingress from routes when CapabilityRoute is disabled

Details

In response to this:

/jira cherry-pick OCPBUGS-80950

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@arolika: This pull request references Jira Issue OCPBUGS-81161, which is invalid:

• expected dependent Jira Issue OCPBUGS-80950 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What this PR does / why we need it:

This is a backport PR to release-4.19 branch. I'm opening this because the [cherrypick PR had merge conflicts.](#8083)
[Original PR can be found here.](#8001)

On IBM Cloud the servicePublishingStrategy: Route can't assume that the management cluster is an OCP cluster, because it still has vanilla k8s management clusters.
When running on vanilla Kubernetes on IBM Cloud (which doesn't have Route CRDs), the operator crashes during reconciliation when attempting to list Route resources.
HyperShift on IBM Cloud should work on both OpenShift and vanilla Kubernetes (IBM Cloud) management clusters, gracefully handling the absence of optional APIs like Route.

The fix is an extra check in the removeHCPIngressFromRoutes() function to return early if the management cluster has no Route capability.

Which issue(s) this PR fixes:

Fixes #OCPBUGS-78778

Special notes for your reviewer:

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[matlaj]

/lgtm
/ok-to-test
/verified by TestRemoveHCPIngressFromRoutes,@arolika

[openshift-ci-robot]

@matlaj: This PR has been marked as verified by TestRemoveHCPIngressFromRoutes,@arolika.

Details

In response to this:

/lgtm
/ok-to-test
/verified by TestRemoveHCPIngressFromRoutes,@arolika

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[arolika]

As discussed privately with @matlaj, I verified this PR on IBM Cloud by deploying a version 4.19 hosted cluster with the changes. The fix functions as intended and I observed no regressions.

[matlaj]

/retest

[matlaj]

/retest

[TwoDCube]

/jira refresh

[openshift-ci-robot]

@TwoDCube: This pull request references Jira Issue OCPBUGS-81161, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.z) matches configured target version for branch (4.19.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-80950 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-80950 targets the "4.20.z" version, which is one of the valid target versions: 4.20.0, 4.20.z
• bug has dependents

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[TwoDCube]

/ok-to-test

[TwoDCube]

/retest

[rtheis]

/lgtm

[openshift-ci]

@arolika: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[sjenning]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arolika, rtheis, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [sjenning]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@arolika: Jira Issue Verification Checks: Jira Issue OCPBUGS-81161
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-81161 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

What this PR does / why we need it:

This is a backport PR to release-4.19 branch. I'm opening this because the [cherrypick PR had merge conflicts.](#8083)
[Original PR can be found here.](#8001)

On IBM Cloud the servicePublishingStrategy: Route can't assume that the management cluster is an OCP cluster, because it still has vanilla k8s management clusters.
When running on vanilla Kubernetes on IBM Cloud (which doesn't have Route CRDs), the operator crashes during reconciliation when attempting to list Route resources.
HyperShift on IBM Cloud should work on both OpenShift and vanilla Kubernetes (IBM Cloud) management clusters, gracefully handling the absence of optional APIs like Route.

The fix is an extra check in the removeHCPIngressFromRoutes() function to return early if the management cluster has no Route capability.

Which issue(s) this PR fixes:

Fixes #OCPBUGS-78778

Special notes for your reviewer:

Checklist:

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-robot]

Fix included in accepted release 4.19.0-0.nightly-2026-04-07-220324