OCPBUGS-74506: Remove ConsolePluginSecurityPolicy featuregate

[jhadvig]

This PR needs to get merged together with console-operator PR in order to get openshift/api#2683 merged

/assign @TheRealJon
@spadgett FYI

Summary by CodeRabbit

• New Features

  • Added KMSEncryption feature gate support for API server encryption.
  • Added IBMCloud and External as supported platform types.

• Deprecations

  • Removed ConsolePluginContentSecurityPolicy feature gate.

• Improvements

  • Enhanced boot image validation rules for automatic mode.
  • Updated API documentation and validation descriptions for improved clarity.

[openshift-ci-robot]

@jhadvig: This pull request references Jira Issue OCPBUGS-74506, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This PR needs to get merged together with console-operator PR in order to get openshift/api#2683 merged

/assign @TheRealJon
@spadgett FYI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request updates the vendored OpenShift API dependency source from github.com/openshift/api to github.com/jhadvig/api with new pseudo-versions. It introduces KMSEncryption feature gate annotations to the API server configuration, removes the ConsolePluginContentSecurityPolicy feature gate from console plugins, and updates enum validation metadata for ConsoleSampleSourceType. Documentation comments and Swagger descriptions across authentication, infrastructure, and API server types are reformatted for clarity. Platform type enumerations are expanded to include IBMCloud and External options, and machine configuration validation rules are refined to enforce stricter constraints on managed boot images in Automatic mode.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: removing the ConsolePluginSecurityPolicy feature gate, which is reflected in the vendor changes removing the annotation and updating feature gate lists.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[jhadvig]

/retest

[jhadvig]

/hold

[openshift-ci-robot]

@jhadvig: This pull request references Jira Issue OCPBUGS-74506. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

This PR needs to get merged together with console-operator PR in order to get openshift/api#2683 merged

/assign @TheRealJon
@spadgett FYI

Summary by CodeRabbit

• New Features

• Added KMSEncryption feature gate support for API server encryption.

• Added IBMCloud and External as supported platform types.

• Deprecations

• Removed ConsolePluginContentSecurityPolicy feature gate.

• Improvements

• Enhanced boot image validation rules for automatic mode.

• Updated API documentation and validation descriptions for improved clarity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@jhadvig: This pull request references Jira Issue OCPBUGS-74506, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This PR needs to get merged together with console-operator PR in order to get openshift/api#2683 merged

/assign @TheRealJon
@spadgett FYI

Summary by CodeRabbit

• New Features

• Added KMSEncryption feature gate support for API server encryption.

• Added IBMCloud and External as supported platform types.

• Deprecations

• Removed ConsolePluginContentSecurityPolicy feature gate.

• Improvements

• Enhanced boot image validation rules for automatic mode.

• Updated API documentation and validation descriptions for improved clarity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• cmd/OWNERS [jhadvig]
• pkg/OWNERS [jhadvig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[krishagarwal278]

Reviewed this PR and lgtm from my end but i'll let @TheRealJon tag 👍🏻 😄

[yapei]

• There is no contentSecurityPolicyEnabled: true in cm/console-config
• content-security-policy-enabled flag no longer exist in bin/bridge
• regression testing about dynamic plugin triggering CSP features pass, CSP settings can be successfully applied & removed and synced to cm/console-config

/verified by @yapei

[openshift-ci-robot]

@yapei: This PR has been marked as verified by @yapei.

Details

In response to this:

• There is no contentSecurityPolicyEnabled: true in cm/console-config
• content-security-policy-enabled flag no longer exist in bin/bridge
• regression testing about dynamic plugin triggering CSP features pass, CSP settings can be successfully applied & removed and synced to cm/console-config

/verified by @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jhadvig]

/hold cancel

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 95a8713 and 2 for PR HEAD 3eb7b68 in total

[jhadvig]

Flakes
/override ci/prow/e2e-gcp-console

[openshift-ci]

@jhadvig: Overrode contexts on behalf of jhadvig: ci/prow/e2e-gcp-console

Details

In response to this:

Flakes
/override ci/prow/e2e-gcp-console

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

@jhadvig: Jira Issue OCPBUGS-74506: Some pull requests linked via external trackers have merged:

The following pull request, linked via external tracker, has not merged:

• openshift/api#2683 is open

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-74506 has not been moved to the MODIFIED state.

This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload.

Details

In response to this:

This PR needs to get merged together with console-operator PR in order to get openshift/api#2683 merged

/assign @TheRealJon
@spadgett FYI

Summary by CodeRabbit

• New Features

• Added KMSEncryption feature gate support for API server encryption.

• Added IBMCloud and External as supported platform types.

• Deprecations

• Removed ConsolePluginContentSecurityPolicy feature gate.

• Improvements

• Enhanced boot image validation rules for automatic mode.

• Updated API documentation and validation descriptions for improved clarity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@jhadvig: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.