Skip to content

jobrunaggregator: add numerical identifiers to job run squares#4901

Draft
petr-muller wants to merge 1 commit intoopenshift:mainfrom
petr-muller:numbers-in-icons
Draft

jobrunaggregator: add numerical identifiers to job run squares#4901
petr-muller wants to merge 1 commit intoopenshift:mainfrom
petr-muller:numbers-in-icons

Conversation

@petr-muller
Copy link
Copy Markdown
Member

Summary

Add stable numerical identifiers (1, 2, 3, ...) to the colored squares in the Spyglass Suite Information HTML artifact. This makes it easy to identify correlations between test failures across different tests.

Changes

  • Add helper functions to collect and number all unique JobRunIDs from the test suite
  • Display numbers on colored squares (red for failures, purple for flakes, green for passes)
  • Numbers are sorted alphabetically by JobRunID for stable, deterministic ordering
  • Same JobRunID shows the same number across all tests in the report
  • Add dict template function to pass multiple values to nested templates

Example

If three tests fail in job run 1234567890, all three will display the same number (e.g., "1") on their red squares, making the correlation immediately visible.

Test plan

  • Code compiles successfully
  • All tests pass
  • Run job-run-aggregator on actual aggregation job
  • Verify numbers appear on squares
  • Verify same JobRunID shows same number across different tests
  • Check visual appearance and readability

🤖 Generated with Claude Code

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 15, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 15, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 15, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Excluded labels (none allowed) (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: df8484aa-6284-4a9d-868d-f8c939b3f8b8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 15, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2026
@petr-muller
Copy link
Copy Markdown
Member Author

Pure Claude work, I'd like to test this first

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 31, 2026

@petr-muller: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Add stable numerical identifiers to colored squares in the Spyglass Suite
Information HTML artifact to help identify correlations between test
failures. When multiple tests fail in the same job run, they display the
same number, making it easier to spot patterns.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants