NO-JIRA: Set agent DISABLE_IMAGE_POLICY for local installs#1867
NO-JIRA: Set agent DISABLE_IMAGE_POLICY for local installs#1867bfournie wants to merge 1 commit intoopenshift-metal3:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/lgtm |
| # Disable image policy verification for local development | ||
| # In CI, this is set via the test configuration (see https://github.com/openshift/installer/pull/10379) | ||
| if [ "${OPENSHIFT_CI}" != "true" ]; then | ||
| export OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY="true" |
There was a problem hiding this comment.
This does not seem correct for all the situation. In particular for the release jobs (or nightly) we want to test a signed payload, isn't it? (I mean locally)
There was a problem hiding this comment.
For nightly builds we'll get a failure if we don't set this. This is required to be set because nightly images are not signed. It is set in CI.
For CI builds this setting is not needed. I can add a clause in to only use for nightly builds.
There was a problem hiding this comment.
Do you mean stable e.g. quay.io/openshift-release-dev/ocp-release:4.21.7-x86_64 ?
No we don't need to disable the signature checking on that, only on nightly builds when we are testing locally
bfournie
force-pushed
the
local-disable-image-policy
branch
from
16b77c1 to
37ad98f
Compare
|
New changes are detected. LGTM label has been removed. |
|
@bfournie: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
I've tested this with: OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY is not set and not needed for install.
OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY not needed for install. OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY set and needed for install, otherwise installation will fail. |
3 participants
In CI, for agent-based installations the environment variable OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY is set and this is passed down to assisted-service. When doing local testing we also need to set this environment variable.