streaming aggregation and progress bar for _run_task_get_arffcontent#1720
Open
yashikavishwakarma wants to merge 2 commits intoopenml:mainfrom
Open
streaming aggregation and progress bar for _run_task_get_arffcontent#1720yashikavishwakarma wants to merge 2 commits intoopenml:mainfrom
yashikavishwakarma wants to merge 2 commits intoopenml:mainfrom
Conversation
…sults and add tqdm progress bar
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation runs all folds in parallel and stores everything
in memory before doing anything with the results. This can be a problem for
large tasks.
This PR changes it to stream results as each fold finishes instead of waiting
for all of them. Also split the big function into smaller ones since it was
getting hard to follow, and added a tqdm progress bar so you can actually
see whats happening while it runs.
Changes:
separate helper functions