[ENH] V1 -> V2 Migration - Flows (module)#1609
Open
Omswastik-11 wants to merge 280 commits intoopenml:mainfrom
Open
[ENH] V1 -> V2 Migration - Flows (module)#1609Omswastik-11 wants to merge 280 commits intoopenml:mainfrom
Omswastik-11 wants to merge 280 commits intoopenml:mainfrom
Conversation
Omswastik-11
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1609 +/- ##
===========================================
+ Coverage 52.73% 81.47% +28.73%
===========================================
Files 37 61 +24
Lines 4399 5085 +686
===========================================
+ Hits 2320 4143 +1823
+ Misses 2079 942 -1137 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Omswastik-11
commented
Jan 14, 2026
Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>
Omswastik-11
force-pushed
the
flow-migration-stacked
branch
from
614411f to
36184e5
Compare
for more information, see https://pre-commit.ci
Contributor
Author
|
Hi @geetu040 !! Can you review the pre-commit failure It was due to merge conflicts more specifically for tasks . Should I change it on my branch ? |
Collaborator
can you try again, sync your branch with mine? It should be fixed now. |
Contributor
Author
|
I think that due to conflicts it did not synced properly . I have to revert it manually |
geetu040
suggested changes
Jan 15, 2026
Collaborator
geetu040
left a comment
geetu040
left a comment
There was a problem hiding this comment.
Nice overall, few changes needed. I'll look at the tests later when the implementation is final.
openml#1576 (comment) Co-authored-by: Pieter Gijsbers <p.gijsbers@tue.nl>
for more information, see https://pre-commit.ci
…into flow-migration-stacked
This reverts commit 93155ee.
geetu040
suggested changes
Mar 13, 2026
Collaborator
geetu040
left a comment
geetu040
left a comment
There was a problem hiding this comment.
update with #1576 (comment)
…into flow-migration-stacked
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 42 out of 43 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
46
to
48
| def _mocked_perform_api_call(call, request_method): | ||
| url = openml.config.server + "/" + call | ||
| url = openml.config.server + call | ||
| return openml._api_calls._download_text_file(url) |
Comment on lines
+455
to
458
| @mock.patch.object(requests.Session, "request") | ||
| def test_delete_flow_not_owned(mock_request, test_files_directory, test_apikey_v1): | ||
| openml.config.start_using_configuration_for_example() | ||
| content_file = test_files_directory / "mock_responses" / "flows" / "flow_delete_not_owned.xml" |
Comment on lines
468
to
+471
| openml.flows.delete_flow(40_000) | ||
|
|
||
| flow_url = f"{openml.config.TEST_SERVER_URL}/api/v1/xml/flow/40000" | ||
| assert flow_url == mock_delete.call_args.args[0] | ||
| assert test_api_key == mock_delete.call_args.kwargs.get("params", {}).get("api_key") | ||
| assert mock_request.call_args.kwargs.get("method") == "DELETE" | ||
| assert test_apikey_v1 == mock_request.call_args.kwargs.get("params", {}).get("api_key") |
Comment on lines
+294
to
+302
| raise ValueError( | ||
| f'invalid api_version="{api_version}" ' | ||
| f"allowed versions: {', '.join(list(APIVersion))}" | ||
| ) | ||
|
|
||
| if fallback_api_version is not None and fallback_api_version not in APIVersion: | ||
| raise ValueError( | ||
| f'invalid fallback_api_version="{fallback_api_version}" ' | ||
| f"allowed versions: {', '.join(list(APIVersion))}" |
Comment on lines
299
to
+310
| TestBase.logger.info(f"collected from {__file__.split('/')[-1]}: {flow.flow_id}") | ||
|
|
||
|
|
||
| @pytest.mark.sklearn() | ||
| @mock.patch("openml.flows.functions.get_flow") | ||
| @mock.patch("openml.flows.functions.flow_exists") | ||
| @mock.patch("openml._api_calls._perform_api_call") | ||
| def test_publish_error(self, api_call_mock, flow_exists_mock, get_flow_mock): | ||
| @mock.patch("requests.Session.request") | ||
| def test_publish_error(self, mock_request, flow_exists_mock, get_flow_mock): | ||
| model = sklearn.ensemble.RandomForestClassifier() | ||
| flow = self.extension.model_to_flow(model) | ||
| api_call_mock.return_value = ( | ||
|
|
||
| # Create mock response directly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1601
added a
Createmethod inFlowAPIfor publishing flow but not refactored with oldpublish. (Needs discussion on this)Added tests using
fake_methodsso that we can test without localV2server . I have tested theFlowsV2methods (getandexists) anddeleteandlistwere not implemented inV2server so I skipped them .