8355249: Remove the use of WMIC from the entire source code#774
8355249: Remove the use of WMIC from the entire source code#774tkiriyama wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back tkiriyama! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
@tkiriyama This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
Would anyone review this fix, please? |
Hi All,
I would like to backport JDK-8355249 done to jdk8.
This backport is not clean and differs in some respects from the fix for JDK 11.
The following files are not present in JDK 8, so no changes are required:
The following two files need to be modified.
The changes to
build-performance.m4are equivalent to those in JDK 11.generated-configure.shexist only in JDK 8. After modifyingbuild-performance.m4, I ranautogen.shto properly regenerategenerate_configure.sh.Thank you.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/774/head:pull/774$ git checkout pull/774Update a local copy of the PR:
$ git checkout pull/774$ git pull https://git.openjdk.org/jdk8u-dev.git pull/774/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 774View PR using the GUI difftool:
$ git pr show -t 774Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/774.diff
Using Webrev
Link to Webrev Comment