Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 28 additions & 8 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@
"url": "https://github.com/openedx/frontend-template-application/issues"
},
"dependencies": {
"@edx/openedx-atlas": "^0.7.0"
"@edx/openedx-atlas": "^0.7.0",
"react-helmet": "^6.1.0"
},
"devDependencies": {
"@edx/browserslist-config": "^1.5.0",
Expand Down
19 changes: 19 additions & 0 deletions src/Main.test.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import { render, waitFor } from '@testing-library/react';
import { BrowserRouter } from 'react-router-dom';
import { IntlProvider } from '@openedx/frontend-base';
import Main from './Main';

describe('Main', () => {
it('sets the document title from the page-title message and site name', async () => {
render(
<IntlProvider locale="en" messages={{}}>
<BrowserRouter>
<Main />
</BrowserRouter>
</IntlProvider>
);
await waitFor(() => {
expect(document.title).toBe('Template | Template Test Site');
});
});
});
28 changes: 20 additions & 8 deletions src/Main.tsx
Original file line number Diff line number Diff line change
@@ -1,15 +1,27 @@
import { CurrentAppProvider } from '@openedx/frontend-base';
import { CurrentAppProvider, getSiteConfig, useIntl } from '@openedx/frontend-base';
import { Helmet } from 'react-helmet';
import { Outlet } from 'react-router-dom';
import { appId } from './constants';
import messages from './messages';

import './style.scss';

const Main = () => (
<CurrentAppProvider appId={appId}>
<main className="d-flex flex-column flex-grow-1">
<Outlet />
</main>
</CurrentAppProvider>
);
const Main = () => {
const { formatMessage } = useIntl();
return (
<CurrentAppProvider appId={appId}>
<Helmet>
<title>
{formatMessage(messages['template.page.title'], {
siteName: getSiteConfig().siteName,
})}
</title>
</Helmet>
<main className="d-flex flex-column flex-grow-1">
<Outlet />
</main>
</CurrentAppProvider>
);
};

export default Main;
11 changes: 11 additions & 0 deletions src/messages.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import { defineMessages } from '@openedx/frontend-base';

const messages = defineMessages({
'template.page.title': {
id: 'template.page.title',
defaultMessage: 'Template | {siteName}',
description: 'Document title for the template app',
},
});

export default messages;
Loading