fix: use running loop in audio helpers#3299
Open
Ghraven wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asyncio.get_event_loop()withasyncio.get_running_loop()in audio helper async methodsProblem
The audio helper methods are already async methods, but they currently call
asyncio.get_event_loop()before using the loop for thread-safe callback notifications and executor work.get_event_loop()has legacy behavior in modern Python when no loop is set by policy; inside async code,get_running_loop()is the clearer and more precise API.Before / After
Before, the helpers asked asyncio for the policy/current loop with
get_event_loop().After, they capture the loop that is actively running the coroutine with
get_running_loop().Verification
python -m compileall -q src\openai\helpers\local_audio_player.py src\openai\helpers\microphone.pygit diff --check