remove unreachable error block in thread. streaming path#3290
Open
rmotgi1227 wants to merge 1 commit into
Open
remove unreachable error block in thread. streaming path#3290rmotgi1227 wants to merge 1 commit into
rmotgi1227 wants to merge 1 commit into
Conversation
'sse.event == "error"' can never be true inside the 'startswith("thread.")'
branch, so the APIError raise block was dead code. The else branch already
handles error events correctly. Remove the dead block from both sync and async paths.
Fixes openai#2796
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sse.event == "error"check nested insidestartswith("thread.")can never be true —"error"does not start with"thread.". The block was dead code. Theelsebranch already handles error events correctly.Removes the unreachable block from both sync and async paths.
Fixes #2796